Events v2: notify country config of new actions performed on events #8322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
naftis
reviewed
Jan 22, 2025
Comment on lines
+43
to
+56
| await fetch( | ||
| new URL( | ||
| `/events/${event.type}/actions/${action.type}`, | ||
| env.COUNTRY_CONFIG_URL | ||
| ), | ||
| { | ||
| method: 'POST', | ||
| body: JSON.stringify(event), | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| Authorization: `Bearer ${token}` | ||
| } | ||
| } | ||
| ) |
There was a problem hiding this comment.
non-200 would not throw, is that okay? consider adding if(!response.ok) ...
PR LGTM after this
There was a problem hiding this comment.
Yea, that's intentional for now 👍
…re into events-v2-notify-cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All actions now trigger a
POST /events/{eventType}/actions/{actionId}request to country config with aEventDocumentpayload. No response is expected from CC. Next step is to expose TRPC commands to country config through which it can confirm the registrationCC: opencrvs/opencrvs-countryconfig#361