feat: create address input #8327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makelicious
approved these changes
Jan 20, 2025
| /> | ||
| ) | ||
| } | ||
| return <div>Unsupported field type {fieldDefinition.type}</div> | ||
| // return <div>Unsupported field type {fieldDefinition.type}</div> |
| return '' | ||
| } | ||
| if (!options) { | ||
| return val as string |
There was a problem hiding this comment.
Any way this could be interpreted?
packages/commons/src/events/utils.ts
Outdated
| type | ||
| })) | ||
| ) | ||
| pages.map(({ fields }) => fields.map((field) => field as FieldConfig)) |
There was a problem hiding this comment.
I think the last map does not do anything except cast the value. By removing it, do you think it will be interpreted right?
There was a problem hiding this comment.
field satisfies FieldConfig throws error here. Seems like .default() in schema has some unexpected effects.
There was a problem hiding this comment.
It might be my earlier mistake. Seems that we are actually passing in
EventConfig, not EventConfigInput
export const findPageFields = (config: EventConfig) => {
return flattenDeep(
config.actions.map(({ forms }) =>
forms.map(({ pages }) =>
pages.map(({ fields }) => fields.map((field) => field))
)
)
) satisfies FieldConfig[]
}
Would this work in your case?
…vs-core into address-input-v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.