Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with formatting national phone numbers for countries with a '0' national prefix #8341

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Fix issue with formatting national phone numbers for countries with a '0' national prefix #8341

merged 2 commits into from
Jan 20, 2025

Conversation

tareq89
Copy link
Collaborator

@tareq89 tareq89 commented Jan 16, 2025

No description provided.

@github-actions GitHub Actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@tareq89 tareq89 requested a review from rikukissa January 16, 2025 13:26
@tareq89 tareq89 self-assigned this Jan 16, 2025
@tareq89 tareq89 added this to the v1.6.3 milestone Jan 16, 2025
@rikukissa rikukissa added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Jan 20, 2025
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://ocrvs-7635.opencrvs.dev

@euanmillar
Copy link
Collaborator

@rikukissa should this milestone be changed to 1.7.0 as we are no longer doing 1.6.3 right?

@rikukissa rikukissa modified the milestones: v1.6.3, v.1.7.0 Jan 20, 2025
@rikukissa
Copy link
Member

@euanmillar Thanks, updated 👍

@tareq89
Copy link
Collaborator Author

tareq89 commented Jan 20, 2025

https://github.com/opencrvs/e2e/actions/runs/12868477344

@tareq89 tareq89 enabled auto-merge (squash) January 20, 2025 13:23
@tareq89 tareq89 deployed to ocrvs-7635 January 20, 2025 13:24 — with GitHub Actions Active
@tareq89 tareq89 merged commit 27cf3fe into develop Jan 20, 2025
54 of 55 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 20, 2025
Placeholder commit for PR #8341
7b6e3c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikukissa rikukissa rikukissa approved these changes

Assignees

@tareq89 tareq89

Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it
Projects
None yet
Milestone
v.1.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tareq89 @ocrvs-bot @euanmillar @rikukissa