-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: decouple workqueue from TCME #8372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
rikukissa
reviewed
Jan 22, 2025
const esClient = getOrCreateClient() | ||
|
||
const hasEventsIndex = await esClient.indices.exists({ | ||
index: getEventAliasName() | ||
index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The events alias has all underlying indices connected to it, so it should contain all events
rikukissa
approved these changes
Jan 23, 2025
…ncrvs-core into events-v2-workqueue
Co-authored-by: Markus Laurila <[email protected]>
makelicious
approved these changes
Jan 27, 2025
jamil314
added a commit
that referenced
this pull request
Feb 3, 2025
* feat: workqueue wip * fix: update types * fix: update types * feat: use default columns from defination of all workqueue * feat: use correct anchor * fix: get config of correct event * fix: use same format for intl as in summarypage * fix: use flattened intl * fix: await not return * fix: revert changes in indexing * fix: revert changes in initialValue * add ready for review and ready to print workqueue * feat: add validation * fix: workqueue in fixture * chore: unused export and import and fixtures * chore: bump up toolkit * fix: refactor and fix types Co-authored-by: Markus Laurila <[email protected]> --------- Co-authored-by: Markus Laurila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.