Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/events client errors #8383

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Fix/events client errors #8383

merged 5 commits into from
Jan 23, 2025

Conversation

makelicious
Copy link
Collaborator

@makelicious makelicious commented Jan 22, 2025

Client had some open warnings and errors. Some changes caused form to crash. There is a possibility that mismatch between toolkit versions made it possible.

  1. Prevent form from crashing due managing state at two levels. Create method for reading state with less re-renders
  2. Clean up missing key warning, add rule to avoid it in the future.

@makelicious makelicious requested a review from rikukissa January 22, 2025 14:46
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@makelicious makelicious requested a review from jamil314 January 22, 2025 14:46
@rikukissa
Copy link
Member

rikukissa commented Jan 23, 2025

@makelicious @jamil314

Screen.Recording.2025-01-23.at.14.06.48.mov

Seems like the form values are flickering between {} and <initial value object>. Fixed after applying these changes

@makelicious makelicious merged commit 8b4cf5b into develop Jan 23, 2025
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants