Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Correction stories b #8435

Merged
merged 41 commits into from
Jan 28, 2025
Merged

[WIP] Correction stories b #8435

merged 41 commits into from
Jan 28, 2025

Conversation

makelicious
Copy link
Collaborator

@makelicious makelicious commented Jan 24, 2025 •
edited by rikukissa
Loading

rikukissa and others added 29 commits January 15, 2025 17:24
@rikukissa
add storybook testing setup for client
01a87c1
@rikukissa
add an example of testing a legacy component in storybook, CI job
1ae11ec
@rikukissa @makelicious
Update packages/client/src/v2-events/features/events/fixtures.ts
ee66373 
Co-authored-by: Markus Laurila <[email protected]>
@rikukissa
Merge branch 'develop' into events-v2-storybook
d2886ab
@rikukissa
add missing license headers
dbc3f20
@rikukissa
fix storybook path
743b37b
@rikukissa
Merge branch 'events-v2-storybook' of github.com:opencrvs/opencrvs-co…
1f134b5 
…re into events-v2-storybook
@rikukissa
use different option
65b0f06
@rikukissa
make visual tests its own separate testing phase
657fdd6
@rikukissa
download full git history
2d66a9d
@rikukissa
add missing header
0d1f0b8
@rikukissa
do fetch with github token
a923f3e
@rikukissa
fix type errors
b81e4cd
@rikukissa
remove import asserts
9abb368
@rikukissa
fix some type errors
11a6f41
@rikukissa
Merge branch 'develop' of github.com:opencrvs/opencrvs-core into even…
88b0daf 
…ts-v2-storybook
@rikukissa
fix type error
494525d
@rikukissa
fix type error
608736e
@rikukissa
use https url for core repo
89b3406
@rikukissa
install storybook plugins for eslint
f77ee76
@rikukissa
remove storybook eslint plugin for now, for whatever reason yarn just…
458232b 
… fails to install it even when it prints out success
@rikukissa
use github toke n to fetch repo
01fd9a9
@rikukissa
cleanup
475534b
@rikukissa
fix linter issues
3dd464b
@rikukissa
Merge branch 'develop' of github.com:opencrvs/opencrvs-core into even…
abaf86a 
…ts-v2-storybook
@rikukissa
add placeholder views and backend handlers for request/approve/reject…
292d2fe 
… corrections
@rikukissa
Merge branch 'events-v2-correction-backend' into correction-stories
6e1c129
@rikukissa
implement correction request views in storybook
6df3c33
@makelicious
Merge branch 'develop' into correction-stories-b
fdb5640
@github-actions GitHub Actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@rikukissa rikukissa added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Jan 27, 2025
@github-actions github-actions bot temporarily deployed to correction-stories-b January 27, 2025 07:48 Inactive
@rikukissa rikukissa temporarily deployed to correction-stories-b January 27, 2025 07:48 — with GitHub Actions Inactive
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://correction-stories-b.opencrvs.dev

@rikukissa rikukissa temporarily deployed to correction-stories-b January 27, 2025 09:06 — with GitHub Actions Inactive
makelicious
makelicious commented Jan 27, 2025
View reviewed changes
packages/client/src/forms/correction/corrector.ts Outdated Show resolved Hide resolved
packages/client/src/v2-events/components/forms/FormFieldGenerator.tsx Outdated Show resolved Hide resolved
packages/client/src/v2-events/components/forms/utils.ts Outdated Show resolved Hide resolved
...rc/v2-events/features/events/actions/correct/request/AdditionalDetails/AdditionalDetails.tsx Outdated

if (!actionConfiguration) {
throw new Error(
'User got to a request correction flow without no configuration defined for this action'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could log out eventId, pageId,actionType

...s/client/src/v2-events/features/events/actions/correct/request/CorrectionRequest.stories.tsx Outdated
import { AppRouter } from '@client/v2-events/trpc'
import { router } from './router'
import { useCorrectionRequestData } from './useCorrectionRequestData'
import * as Request from '.'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work almost all the time. maybe if linting could be used to use the filename

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, not the most obvious import syntax

packages/client/src/v2-events/features/events/useEventFormData.ts Show resolved Hide resolved
packages/client/src/v2-events/features/workqueues/router.tsx Outdated Show resolved Hide resolved
packages/client/src/v2-events/features/workqueues/router.tsx Show resolved Hide resolved
packages/events/src/service/events/actions/reject-correction.ts Outdated Show resolved Hide resolved
packages/events/src/service/events/actions/validate.ts Show resolved Hide resolved
@rikukissa rikukissa temporarily deployed to correction-stories-b January 28, 2025 06:22 — with GitHub Actions Inactive
@rikukissa rikukissa enabled auto-merge (squash) January 28, 2025 06:23
@rikukissa rikukissa temporarily deployed to correction-stories-b January 28, 2025 06:30 — with GitHub Actions Inactive
@rikukissa rikukissa mentioned this pull request Jan 28, 2025
Closed
@rikukissa rikukissa temporarily deployed to correction-stories-b January 28, 2025 10:10 — with GitHub Actions Inactive
@rikukissa rikukissa temporarily deployed to correction-stories-b January 28, 2025 12:31 — with GitHub Actions Inactive
@makelicious makelicious added 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it and removed 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it labels Jan 28, 2025
@github-actions github-actions bot deployed to correction-stories-b January 28, 2025 13:11 Active
@rikukissa rikukissa disabled auto-merge January 28, 2025 13:33
@rikukissa rikukissa merged commit 1cbf15f into develop Jan 28, 2025
96 of 97 checks passed
jamil314 pushed a commit that referenced this pull request Feb 3, 2025
@makelicious @rikukissa @jamil314
[WIP] Correction stories b (#8435)
c748827 
Co-authored-by: Markus Laurila <[email protected]>
Co-authored-by: Riku Rouvila <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikukissa rikukissa rikukissa left review comments

Assignees
No one assigned
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makelicious @ocrvs-bot @rikukissa