feat: Reason for delayed registration in v2 birth #390
+51
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
makelicious
reviewed
Jan 31, 2025
src/form/tennis-club-membership.ts
Outdated
| @@ -57,6 +57,7 @@ const TENNIS_CLUB_FORM = defineForm({ | |||
| { | |||
| id: 'applicant.firstname', | |||
| type: 'TEXT', | |||
| options: { maxLength: 32 }, | |||
There was a problem hiding this comment.
Could this be added as constant to ease up the development and possible refactoring
| @@ -329,7 +331,7 @@ export const getPersonInputCommonFields = ( | |||
| }, | |||
| ...getIdFields(person), | |||
| { | |||
| id: `${person}.address.divider.start`, | |||
| id: `${person}.addressDivider_1`, | |||
There was a problem hiding this comment.
any reason for changing casing here?
There was a problem hiding this comment.
This was done so that ES would not nest the dot separated fields
makelicious
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.