-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace boto3 with numpy #713
Conversation
27a16ea
to
f41c199
Compare
9607336
to
285770b
Compare
@diegolovison: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci test failures look unrelated, ignoring this for now |
The issue resolved by this Pull Request:
Resolves https://issues.redhat.com/browse/RHOAIENG-13915
Description of your changes:
Explanation of
pip download
andpip install
pip download: This command fetches packages and their dependencies without installing them. It is crucial that the version of Python for which the packages are downloaded matches the version in the target runtime environment. If you run
pip download
in an environment with Python 3.9, but your target system uses Python 3.10, there could be incompatibilities.pip install: This installs the downloaded packages into the runtime environment. Without a Dockerfile, installation can be influenced by the host environment’s Python version, leading to mismatches between the development, testing, and production environments.
Replacement of boto3 with numpy. It has low dependency artifacts.
Environment-Agnostic Package Management:
3.9
,3.10
,3.11
,3.12
), ensuring compatibility with different runtime environments.Dockerfile and Shell Script Updates:
Dockerfile
By using Docker, we create a containerized environment where the Python version is explicitly defined, making the process environment agnostic. The Docker container ensures that no matter where the code runs, the same Python version and packages are used, avoiding discrepancies between development machines, CI/CD pipelines, and production.
This solves the problems with pip download and pip install ( as described above )
Testing instructions
Not needed. It was done by GHA
Checklist