Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boto3 with numpy #713

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

diegolovison
Copy link
Contributor

@diegolovison diegolovison commented Oct 3, 2024

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-13915

Description of your changes:

Explanation of pip download and pip install

  • pip download: This command fetches packages and their dependencies without installing them. It is crucial that the version of Python for which the packages are downloaded matches the version in the target runtime environment. If you run pip download in an environment with Python 3.9, but your target system uses Python 3.10, there could be incompatibilities.

  • pip install: This installs the downloaded packages into the runtime environment. Without a Dockerfile, installation can be influenced by the host environment’s Python version, leading to mismatches between the development, testing, and production environments.

  1. Replacement of boto3 with numpy. It has low dependency artifacts.

  2. Environment-Agnostic Package Management:

    • Download packages for multiple Python versions (3.9, 3.10, 3.11, 3.12), ensuring compatibility with different runtime environments.
  3. Dockerfile and Shell Script Updates:

    • This makes the process more reliable by standardizing the environment, making it easier to manage dependencies for pipelines.

Dockerfile

By using Docker, we create a containerized environment where the Python version is explicitly defined, making the process environment agnostic. The Docker container ensures that no matter where the code runs, the same Python version and packages are used, avoiding discrepancies between development machines, CI/CD pipelines, and production.

This solves the problems with pip download and pip install ( as described above )

Testing instructions

Not needed. It was done by GHA

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@diegolovison diegolovison force-pushed the boto_np branch 8 times, most recently from 27a16ea to f41c199 Compare October 3, 2024 20:24
@diegolovison diegolovison marked this pull request as draft October 3, 2024 20:24
@diegolovison diegolovison force-pushed the boto_np branch 14 times, most recently from 9607336 to 285770b Compare October 4, 2024 15:30
@diegolovison diegolovison marked this pull request as ready for review October 4, 2024 15:48
@openshift-ci openshift-ci bot requested a review from gmfrasca October 4, 2024 15:48
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

@diegolovison: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-test-odh-dspo 148d64e link true /test integration-test-odh-dspo

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@HumairAK
Copy link
Contributor

HumairAK commented Oct 4, 2024

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2024
@HumairAK
Copy link
Contributor

HumairAK commented Oct 4, 2024

openshift-ci test failures look unrelated, ignoring this for now

@HumairAK HumairAK merged commit bf8f7a2 into opendatahub-io:main Oct 4, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants