Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Tekton Triggers #438

Closed
michaelsauter opened this issue Feb 9, 2022 · 0 comments · Fixed by #439
Closed

Remove Tekton Triggers #438

michaelsauter opened this issue Feb 9, 2022 · 0 comments · Fixed by #439
Assignees
@michaelsauter
Milestone
0.3.0

Comments

@michaelsauter
Copy link
Member

At the moment we add an interceptor in the Tekton Triggers chain to pull off "CI as code". This was done in an attempt to stay close to "official" usage of Tekton.

It turns out we gain very little from this and needlessly complicate the architecture. Further, design proposal #407 (which aims to fix #394) requires that we control the creation of PipelineRun resources, which prevents us from using Tekton Triggers.

Note that other projects (e.g. https://github.com/openshift-pipelines/pipelines-as-code) also do not use Tekton Triggers.

Therefore we are going to remove it. We only need to replicate two things in our own code:

  1. validation of webhook
  2. creation of pipeline run
@michaelsauter michaelsauter added this to the 0.3.0 milestone Feb 9, 2022
@michaelsauter michaelsauter self-assigned this Feb 9, 2022
michaelsauter added a commit that referenced this issue Feb 9, 2022
@michaelsauter
Remove Tekton Triggers
6d70278 
Closes #438.

All required functionality is now part of the ODS pipeline manager.

Required for pipeline queueing, which is required to avoid pipeline run
race conditions.
@michaelsauter michaelsauter mentioned this issue Feb 9, 2022
Merged
4 tasks
michaelsauter added a commit that referenced this issue Feb 9, 2022
@michaelsauter
Remove Tekton Triggers
3d5c064 
Closes #438.

All required functionality is now part of the ODS pipeline manager.

Required for pipeline queueing, which is required to avoid pipeline run
race conditions.
michaelsauter added a commit that referenced this issue Feb 9, 2022
@michaelsauter
Remove Tekton Triggers
cc9df4c 
Closes #438.

All required functionality is now part of the ODS pipeline manager.

Required for pipeline queueing, which is required to avoid pipeline run
race conditions.
michaelsauter added a commit that referenced this issue Feb 9, 2022
@michaelsauter
Remove Tekton Triggers
b2af12f 
Closes #438.

All required functionality is now part of the ODS pipeline manager.

Required for pipeline queueing, which is required to avoid pipeline run
race conditions.
michaelsauter added a commit that referenced this issue Feb 14, 2022
@michaelsauter
Remove Tekton Triggers
b64b383 
Closes #438.

All required functionality is now part of the ODS pipeline manager.

Required for pipeline queueing, which is required to avoid pipeline run
race conditions.

Potentially, this could help with #397 as well.
michaelsauter added a commit that referenced this issue Feb 14, 2022
@michaelsauter
Remove Tekton Triggers
7d6a96d 
Closes #438.

All required functionality is now part of the ODS pipeline manager.

Required for pipeline queueing, which is required to avoid pipeline run
race conditions.

Potentially, this could help with #397 as well.
michaelsauter added a commit that referenced this issue Feb 14, 2022
@michaelsauter
Remove Tekton Triggers
4ed78e4 
Closes #438.

All required functionality is now part of the ODS pipeline manager.

Required for pipeline queueing, which is required to avoid pipeline run
race conditions.

Potentially, this could help with #397 as well.
michaelsauter added a commit that referenced this issue Feb 14, 2022
@michaelsauter
Remove Tekton Triggers
4149bc9 
Closes #438.

All required functionality is now part of the ODS pipeline manager.

Required for pipeline queueing, which is required to avoid pipeline run
race conditions.

Potentially, this could help with #397 as well.
michaelsauter added a commit that referenced this issue Feb 14, 2022
@michaelsauter
Remove Tekton Triggers
132cb13 
Closes #438.

All required functionality is now part of the ODS pipeline manager.

Required for pipeline queueing, which is required to avoid pipeline run
race conditions.

Potentially, this could help with #397 as well.
michaelsauter added a commit that referenced this issue Feb 15, 2022
@michaelsauter
Remove Tekton Triggers
ff105da 
Closes #438.

All required functionality is now part of the ODS pipeline manager.

Required for pipeline queueing, which is required to avoid pipeline run
race conditions.

Potentially, this could help with #397 as well.
michaelsauter added a commit that referenced this issue Feb 15, 2022
@michaelsauter
Remove Tekton Triggers
efff388 
Closes #438.

All required functionality is now part of the ODS pipeline manager.

Required for pipeline queueing, which is required to avoid pipeline run
race conditions.

Potentially, this could help with #397 as well.
@michaelsauter michaelsauter mentioned this issue Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelsauter michaelsauter

Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Remove Tekton Triggers opendevstack/ods-pipeline
1 participant
@michaelsauter