This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
validateUrl: Increasing valid TLD length to 63 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to RFC1035 (https://tools.ietf.org/html/rfc1035), the maximum size of a label is 63 octets. We need this increased because we use a domain that is larger than 4 characters. We cannot setup alerts as a result.
|
Thanks @systemizer, Could you add a quick unit test to make sure we don't regress in the future :) |
mihirsoni
approved these changes
Jan 17, 2020
dbbaughe
approved these changes
Jan 17, 2020
|
Thanks @systemizer ! |
ylwu-amzn
added a commit
to ylwu-amzn/alerting-kibana-plugin
that referenced
this pull request
May 5, 2020
…csearch#115) * Increasing valid TLD length to 63 According to RFC1035 (https://tools.ietf.org/html/rfc1035), the maximum size of a label is 63 octets. We need this increased because we use a domain that is larger than 4 characters. We cannot setup alerts as a result. * Add validateUrl test for TLD with >4 characters * Adding validateUrl test for TLD with >63 characters
ylwu-amzn
added a commit
that referenced
this pull request
May 5, 2020
* validateUrl: Increasing valid TLD length to 63 (#115) * Increasing valid TLD length to 63 According to RFC1035 (https://tools.ietf.org/html/rfc1035), the maximum size of a label is 63 octets. We need this increased because we use a domain that is larger than 4 characters. We cannot setup alerts as a result. * Add validateUrl test for TLD with >4 characters * Adding validateUrl test for TLD with >63 characters * anomaly detection changes. (#123) * anomaly detection changes. Co-authored-by: mihirsoni <[email protected]> * remove anomaly detector option when create monitor if AD plugin not installed * address comments: copyright, remove unused code,etc * remove extra showLoader Co-authored-by: mihirsoni <[email protected]> * change words and padding according to ux review comments (#132) * change words and padding according to ux review comments * fix padding of monitor schedule * rename monitor method description according to UX review comments (#133) * fix snapshot test and validate unit test Co-authored-by: mihirsoni <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC1035 (https://tools.ietf.org/html/rfc1035), the maximum size of a label is 63 octets.
We need this increased because we use a TLD that is larger than 4 characters. We cannot setup alerts as a result.
Description of changes:
This updates the
validateUrlfunction to accept urls with TLDs up to 63 octets (consist with the RFC1035)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.