-
Notifications
You must be signed in to change notification settings - Fork 80
Inject roles for alerting background jobs #259
Conversation
…tination response, 3/ handle null in GetMonitorRequest
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
=========================================
Coverage 80.37% 80.37%
Complexity 199 199
=========================================
Files 149 150 +1
Lines 4810 4897 +87
Branches 635 647 +12
=========================================
+ Hits 3866 3936 +70
- Misses 597 608 +11
- Partials 347 353 +6 Continue to review full report at Codecov.
|
/* | ||
* Commented. This test is not relevant anymore. We can't create a monitor with illegal chars. | ||
* This is replaced with MonitorRestApiIT.`test creating a monitor with illegal index name` | ||
*/ | ||
/*fun `test execute monitor with bad search`() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why note remove the code since it has essentially became dead code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Adding comments here and deleting the dead code.
* Commented. This test is not relevant anymore. We can't create a monitor with illegal chars.
* This is replaced with MonitorRestApiIT.`test creating a monitor with illegal index name`
@@ -18,7 +18,7 @@ | |||
import org.elasticsearch.common.Strings; | |||
|
|||
/** | |||
* This class is a place holder for destination response metadata | |||
` * This class is a place holder for destination response metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this accidentally added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, fixed
* Inject roles for background jobs * Removed dead test
* Inject roles for background jobs * Removed dead test
Issue #, if available:
#215
Description of changes:
#215
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.