fix(ci): build images before running sanity test #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niladri Halder <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #129 +/- ##
========================================
Coverage 49.79% 49.79%
========================================
Files 38 38
Lines 2705 2705
========================================
Hits 1347 1347
Misses 1255 1255
Partials 103 103 Continue to review full report at Codecov.
|
niladrih
added a commit
to niladrih/dynamic-nfs-provisioner
that referenced
this pull request
Dec 10, 2021
Signed-off-by: Niladri Halder <[email protected]>
niladrih
added a commit
to niladrih/dynamic-nfs-provisioner
that referenced
this pull request
Dec 10, 2021
Signed-off-by: Niladri Halder <[email protected]>
niladrih
added a commit
to niladrih/dynamic-nfs-provisioner
that referenced
this pull request
Dec 10, 2021
Signed-off-by: Niladri Halder <[email protected]>
niladrih
added a commit
to niladrih/dynamic-nfs-provisioner
that referenced
this pull request
Dec 10, 2021
Signed-off-by: Niladri Halder <[email protected]>
niladrih
added a commit
to niladrih/dynamic-nfs-provisioner
that referenced
this pull request
Dec 10, 2021
Signed-off-by: Niladri Halder <[email protected]>
niladrih
added a commit
to niladrih/dynamic-nfs-provisioner
that referenced
this pull request
Dec 10, 2021
Signed-off-by: Niladri Halder <[email protected]>
…anity-test job item higher up the list for readability Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
mittachaitu
reviewed
Dec 10, 2021
| @@ -12,7 +12,7 @@ | |||
| #See the License for the specific language governing permissions and | |||
| #limitations under the License. | |||
| # | |||
| FROM alpine:3.11.5 | |||
| FROM alpine:3.12 | |||
There was a problem hiding this comment.
Info: Changes in this file are done to sync with buildx docker file.
Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
niladrih
added a commit
to niladrih/dynamic-nfs-provisioner
that referenced
this pull request
Dec 13, 2021
Signed-off-by: Niladri Halder <[email protected]>
mittachaitu
reviewed
Dec 13, 2021
| # to ignore builds on release | ||
| if: ${{ (github.event.ref_type != 'tag') }} | ||
| runs-on: ubuntu-latest | ||
| needs: ['lint', 'unit-test'] |
There was a problem hiding this comment.
@niladrih Running sanity test parallel is causing test to get timeout(May be due to less resources)
There was a problem hiding this comment.
One of the tests failed a due to 404 error.
2 other sanity-tests running in #272 and #273 passed.
Likely cause is test flakiness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Niladri Halder [email protected]
Why is this PR required? What issue does it fix?:
The GitHub Actions CI runs
make sanity-testagainst existing docker hub images. The images with the changes are not built correctly before running the sanity test. The sanity test does not produce results against the latest changes.Additionally, the apt install for the nfs-common prerequisite will require interactive Y/N command if the nfs-common prerequisite is absent, and the install needs to go through. Added the
-yflag to make the Y option non-interactive.What this PR does?:
Build workflow: Both the provisioner-nfs and nfs-server-alpine image builds are added before the test run.
Pull Request workflow: The build for the nfs-server-alpine image is now added.
The Dockerfile file in buildscripts/provisioner-nfs/ directory now uses the same base image as provisioner-nfs.Dockerfile.
Changed the CMD directive to ENTRYPOINT directive in 'Dockerfile' file.
Go setup in GitHub actions is added to provisioner-nfs workflow.
Updated minikube action to latest version -- 2.4.2
Minikube used is now v1.24.0
Kubernetes version is now 1.20.13
Added flag to disable minikube storage-provisioner addon (nfs_claim_released_pv test, nfs_sc_delayed_binding_test.go, nfs_server_param_test.go now use openebs-hostpath BackendStorageClass instead of the default one)
Build and Pull Request workflow runs will be avoided for pushes to docs/ directory
The sanity-test now runs in parallel with the multi-arch build tests for the provisioner-nfs and nfs-server-alpine image.
Does this PR require any upgrade changes?:
No.
If the changes in this PR are manually verified, list down the scenarios covered::
Not manually verified.
Any additional information for your reviewer? :
The PR #125 depends on this.