fix: Update retry logic for certain ansible tasks.

When we added retry logic, we missed that we also needed
to register a variable and add an until condition to ensure
that retries happen. This should ensure that this matches.

edx/edx-arch-experiments#359

playbooks/roles/insightvm_agent/tasks/main.yml

@@ -11,6 +11,7 @@
     path: /etc/systemd/system/ir_agent.service
   register: r7_service
   retries: 3
+  until: r7_service is succeeded
   tags:
     - manage_rapid7_check_agent
 

playbooks/roles/security/tasks/security-amazon.yml

@@ -30,7 +30,9 @@
 - name: "Take security updates during ansible runs"
   command: "{{ item }}"
   when: SECURITY_UPGRADE_ON_ANSIBLE
+  register: result_amazon
   retries: 3
+  until: result_amazon is succeeded
   with_items:
     - yum check-update --security
     - yum update --security -y

playbooks/roles/security/tasks/security-ubuntu.yml

@@ -24,7 +24,9 @@
 - name: Disable unattended-upgrades if Xenial (16.04)
   command: "{{ item }}"
   when: ansible_distribution_release == 'xenial' and not SECURITY_UNATTENDED_UPGRADES
+  register: result_ubuntu
   retries: 3
+  until: result_ubuntu is succeeded
   with_items:
     - "systemctl disable apt-daily.service"
     - "systemctl disable apt-daily.timer"