Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

UI: Payment Page clean-up #47

Merged
merged 4 commits into from
Jul 3, 2019
Merged

Conversation

julianajlk
Copy link
Contributor

@julianajlk julianajlk commented Jul 2, 2019

Clean-up include:

  • Post and Delete coupon now return the complete basket page (bug on saga with duplicate addCouponSuccess is fixed).
  • Discount line no longer displayed when there is no discount .
  • "In your cart" to "In Your Cart"
  • Changed section headings to h5 className.

FYI @edx/arch-squad

@julianajlk julianajlk requested a review from a team July 2, 2019 19:18
@julianajlk julianajlk force-pushed the julianajlk/ARCH-977-ui-cleanup branch from 6362a44 to 6548cbf Compare July 2, 2019 19:58
@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #47   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          31     31           
  Lines         317    319    +2     
  Branches       44     45    +1     
=====================================
+ Hits          317    319    +2
Impacted Files Coverage Δ
src/payment/ProductLineItem.jsx 100% <ø> (ø) ⬆️
src/payment/ProductLineItems.jsx 100% <ø> (ø) ⬆️
src/payment/PaymentForm.jsx 100% <ø> (ø) ⬆️
src/payment/coupon/data/service.js 100% <100%> (ø) ⬆️
src/payment/BasketSummary.jsx 100% <100%> (ø) ⬆️
src/payment/coupon/data/sagas.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e0483...d62edfb. Read the comment docs.

@julianajlk julianajlk merged commit 9ed5373 into master Jul 3, 2019
@julianajlk julianajlk deleted the julianajlk/ARCH-977-ui-cleanup branch July 3, 2019 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants