Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update PR template to something people might actually use #243

Merged
merged 7 commits into from
Mar 17, 2023

Commits on Aug 11, 2022

  1. feat: Update PR template to something people might actually use

    I notice that people largely ignore PR templates, *especially* big ones.
    I think that shrinking this down to just the essentials will increase the
    likelihood that people use it.
    
    In particular, I want to remove things like "All reviewers approved" and
    "CI build is green" that are generally already enforced by repo policies,
    "Delete working branch" (there's a setting for that if we want it!), and
    release instructions (should be in a central document linked from the
    README).
    timmc-edx committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3dde417 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. fixup! Mention conventional commits as well

    Co-authored-by: Kyle McCormick <[email protected]>
    timmc-edx and kdmccormick authored Mar 7, 2023
    Configuration menu
    Copy the full SHA
    4557e8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    89c52b7 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. fixup! Split PR template out and customize for each cookiecutter type

    - Emphasize "or" in prelude
    - Remove conventional commits link
    - Add unit tests, manual testing; remove "testing instructions" from
      catchall
    - Prune irrelevant items by type: No version bump or changelog for IDA; no
      manual testing for library.
    
    app and xblock are identical, but probably should differ in some way. The
    repo's own template is adjusted to match app/xblock, but without version
    bump or migration note.
    timmc-edx committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    621de0b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    97ac82c View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Merge branch 'master' into timmc/prt

    # Conflicts:
    #	CHANGELOG.rst
    timmc-edx committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    d66b1e1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34a6eea View commit details
    Browse the repository at this point in the history