fix: exceptional case with JwtAuthentication #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes exceptional case where JwtAuthentication should not CSRF protect a request that has both a JWT token in the authorization header and a JWT cookie, since the cookie should be ignored.
robrap
force-pushed
the
robrap/adjust-cookie-logic
branch
from
9d1748f
to
e2577db
Compare
robrap
commented
Aug 31, 2023
feanil
approved these changes
Aug 31, 2023
Updated one of the values of the custom attribute jwt_auth_result from 'skipped' to 'n/a'.
robrap
force-pushed
the
robrap/adjust-cookie-logic
branch
from
dd9c047
to
ecd2ba1
Compare
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes exceptional case where JwtAuthentication should not CSRF protect a request that has both a JWT token in the authorization header and a JWT cookie, since the cookie should be ignored.
Note: I had minor concerns that Mobile could have issues here, and I just didn't want to have that concern, so I took care of the exceptional case.
Merge checklist:
Post merge:
finished.