feat: handle jwt cookie vs session user mismatch #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrap
force-pushed
the
robrap/jwt-vs-session-monitoring
branch
4 times, most recently
from
66b4b86
to
b7a5229
Compare
Adds toggle EDX_DRF_EXTENSIONS[ENABLE_JWT_VS_SESSION_USER_MONITORING] to enable the following features: - New custom attributes is_jwt_vs_session_user_check_enabled, jwt_auth_session_user_id, jwt_auth_and_session_user_mismatch, and invalid_jwt_cookie_user_id for monitoring and debugging. - When forgiving JWT cookies are also enabled, user mismatches will now result in a failure, rather than a forgiving JWT.
robrap
force-pushed
the
robrap/jwt-vs-session-monitoring
branch
from
b7a5229
to
d41ac06
Compare
robrap
changed the title
feanil
reviewed
Oct 5, 2023
- add separate methods to find mismatch with successful and failed JWT, to make differences more clear. - add additional values for ``failed_jwt_cookie_user_id`` in the case that the user_id is not found, or the JWT can't be decoded. - typo fix.
|
@feanil: This is ready for re-review. |
feanil
approved these changes
Oct 10, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds toggle
EDX_DRF_EXTENSIONS[ENABLE_JWT_VS_SESSION_USER_MONITORING]
to enable the following features:
jwt_auth_session_user_id, jwt_auth_and_session_user_mismatch,
and invalid_jwt_cookie_user_id for monitoring and debugging.
will now result in a failure, rather than a forgiving JWT.
This implements #381 (comment).
Merge checklist:
Post merge:
finished.