Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serialize best_mode_for_course_run field in DefaultEnterpriseEnrollmentIntentionSerializer #2277

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Oct 30, 2024

Description

Exposes best_mode_for_course_run in DefaultEnterpriseEnrollmentIntentionSerializer, which will be used when attempting bulk enrollment for enrollable default enterprise enrollment intentions. That is, the bulk enrollment API accepts a mode property, which best_mode_for_course_run will be passed.

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production but edx-platform doesn't install it
    • test-master.in if edx-platform pins it, with a matching version
    • make upgrade && make requirements have been run to regenerate requirements
  • make static has been run to update webpack bundling if any static content was updated
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
    • This should be run from either a venv with all the lms/edx-enterprise requirements installed or if you checked out edx-enterprise into the src directory used by lms, you can run this command through an lms shell.
      • It would be ./manage.py lms makemigrations in the shell.
  • Version bumped
  • Changelog record added
  • Translations updated (see docs/internationalization.rst but also this isn't blocking for merge atm)

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in edx-platform to upgrade dependencies (including edx-enterprise)
    • Trigger the 'Upgrade one Python dependency' action against master in edx-platform with new version number to generate version bump PR
    • This must be done after the version is visible in PyPi as make upgrade in edx-platform will look for the latest version in PyPi.
    • Note: the edx-enterprise constraint in edx-platform must also be bumped to the latest version in PyPi.

@adamstankiewicz adamstankiewicz marked this pull request as ready for review October 30, 2024 15:57
@adamstankiewicz adamstankiewicz force-pushed the ags/ent-9684-pt2 branch 2 times, most recently from b7efc8f to 75a69ff Compare October 30, 2024 16:05
@adamstankiewicz adamstankiewicz changed the base branch from ags/ent-9684 to master October 30, 2024 16:05
@adamstankiewicz adamstankiewicz merged commit f3092a7 into master Oct 30, 2024
14 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/ent-9684-pt2 branch October 30, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants