Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test cases for newly added unlink_self endpoint #2282

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Nov 5, 2024

Description
This PR cover up test cases for the changes made in #2279

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production but edx-platform doesn't install it
    • test-master.in if edx-platform pins it, with a matching version
    • make upgrade && make requirements have been run to regenerate requirements
  • make static has been run to update webpack bundling if any static content was updated
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
    • This should be run from either a venv with all the lms/edx-enterprise requirements installed or if you checked out edx-enterprise into the src directory used by lms, you can run this command through an lms shell.
      • It would be ./manage.py lms makemigrations in the shell.
  • Version bumped
  • Changelog record added
  • Translations updated (see docs/internationalization.rst but also this isn't blocking for merge atm)

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in edx-platform to upgrade dependencies (including edx-enterprise)
    • Trigger the 'Upgrade one Python dependency' action against master in edx-platform with new version number to generate version bump PR
    • This must be done after the version is visible in PyPi as make upgrade in edx-platform will look for the latest version in PyPi.
    • Note: the edx-enterprise constraint in edx-platform must also be bumped to the latest version in PyPi.

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/vsf-changes-test branch 2 times, most recently from e41509e to 18b21f7 Compare November 6, 2024 08:21
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also cover the unhappy path? For example, a test for when a learner is not already linked, or a test that verifies an appropriate error is thrown if the POST request fails or any other error occurs?

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/vsf-changes-test branch 2 times, most recently from b215a15 to d4024b0 Compare November 6, 2024 10:58
@jajjibhai008 jajjibhai008 merged commit 5e37239 into master Nov 6, 2024
10 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/vsf-changes-test branch November 6, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants