Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin tox #336

Closed
jmbowman opened this issue May 3, 2023 · 2 comments
Closed

Unpin tox #336

jmbowman opened this issue May 3, 2023 · 2 comments
Assignees

Comments

@jmbowman
Copy link

jmbowman commented May 3, 2023

We pinned tox back in December because the 4.0.0 release broke most of our CI runs. It's quite possible that this has been resolved by now, so we should attempt to remove this pin (requested by Axim in https://openedx.slack.com/archives/C0497NQCLBT/p1682004301805179).

Proposed A/C:

  • Use the workaround from the Slack thread above to allow upgrading tox in edx-platform (chosen because it's the repo most likely to hit nasty corner cases in almost any upgrade). If CI fails with the latest version, spend a little time attempting to resolve.
  • If we can get edx-platform CI working with the latest tox release, merge the PR with those changes. If any changes were needed which are also likely to be needed in other repos upgrading to the latest version, announce them via all appropriate communications channels.
  • If all the above goes well, remove the pin from common_constraints.txt so other repos can upgrade tox normally.
  • Remove the edx-platform workaround for the common tox constraint, if it was merged.
@jmbowman jmbowman moved this to Todo in Arbi-BOM May 3, 2023
@jmbowman jmbowman added this to Arbi-BOM May 3, 2023
@jmbowman
Copy link
Author

Another reason to get this done: the old version of tox depends on the py package, which has an outstanding security flaw. It doesn't impact us (only exploitable if used in conjunction with a Subversion repository), but it clutters up the security dashboard with issues we'll otherwise need to manually inspect and dismiss in dozens of repositories.

@iamsobanjaved
Copy link
Contributor

Need the following issue to be done, before we can remove the tox constraint from common constraints. Because whitelist_externals is removed from tox version 4.0.0. While we can do the first step mentioned in the description, unpin explicitly in edx-platform by removing tox constraint using sed command in make upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants