Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox<4.0.0 as a constraint in every repo that uses tox and tox-battery #217

Closed
67 tasks
Tracked by #191
feanil opened this issue Oct 17, 2023 · 2 comments
Closed
67 tasks
Tracked by #191
Assignees

Comments

@feanil
Copy link

feanil commented Oct 17, 2023

Context

The tox-battery python package provides only one feature to the tox tool. It detects changes to the requirements files that are the deps of a tox environment and optionally re-builds the environments if there are changes to the requirements. The tox-battery package can't run with tox 4.0.0 because of incompatibilites. So make upgrade won't upgrade us to the latest version of tox in a bunch of repos. However tox>=4.0.0 has the requirements monitoring feature built-in and if we drop the tox-battery dependency, we'll get the latest tox with the right featureset.

Tasks

  • In each repo that has both tox and tox-battery as requirements, add a local constraint to constraints.txt
  • Create the PR and tag @feanil for review.

Relevant repos

  • api-doc-tools
  • auth-backends
  • bok-choy
  • code-annotations
  • codejail-includes
  • completion
  • devstack
  • django-config-models
  • django-lang-pref-middleware
  • django-pyfs
  • django-splash
  • django-user-tasks
  • ecommerce
  • ecommerce-worker
  • edx-ace
  • edx-analytics-dashboard
  • edx-analytics-data-api
  • edx-bulk-grades
  • edx-celeryutils
  • edx-cookiecutters
  • edx-django-utils
  • edx-enterprise
  • edx-enterprise-data
  • edx-enterprise-subsidy-client
  • edx-lint
  • edx-milestones
  • edx-notes-api
  • edx-platform
  • edx-proctoring
  • edx-rbac
  • edx-repo-health
  • edx-rest-api-client
  • edx-sphinx-theme
  • edx-toggles
  • edx-val
  • edx-when
  • enterprise-catalog
  • enterprise-subsidy
  • event-bus-kafka
  • event-bus-redis
  • event-routing-backends
  • event-tracking
  • help-tokens
  • opaque-keys
  • openedx-events
  • openedx-event-sink-clickhouse
  • openedx-filters
  • openedx-learning
  • openedx-ledger
  • pytest-repo-health
  • pytest-warnings-report
  • repo-tools-data-schema
  • super-csv
  • taxonomy-connector
  • testeng-ci
  • web-fragments
  • xapi-db-load
  • XBlock
  • xblock-drag-and-drop-v2
  • xblock-google-drive
  • xblock-sdk
  • xblock-skill-tagging
  • xblock-utils
  • xqueue
  • xss-utils

Acceptance Criteria

  • All repos mentioned above have a local constraint that prevents tox from being upgraded.
@thezaeemaanwar
Copy link

thezaeemaanwar commented Oct 31, 2023

In ecommerce repo, tox==3.14.6 is already there so not adding into that one

@thezaeemaanwar
Copy link

thezaeemaanwar commented Nov 7, 2023

As per discussion with @openedx/arbi-bom, they're already working on it.
See openedx/edx-lint#336

@thezaeemaanwar thezaeemaanwar moved this from 🏗 In progress to ✅ Done in Aximprovements Team Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants