Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python3.8 from support #412

Merged
merged 3 commits into from
Sep 16, 2024
Merged

drop python3.8 from support #412

merged 3 commits into from
Sep 16, 2024

Conversation

felipemontoya
Copy link
Member

@felipemontoya felipemontoya commented Sep 4, 2024

This PR is investigating if I can solve the issues with the update bot by dropping support for 3.8 now that redwood is cut.

https://openedx.atlassian.net/wiki/spaces/COMM/pages/4160847886/2024-04-11+Meeting+notes

From #415:

  • Update the tox.ini, setup.py, setup.cfg, or pyproject.toml to remove Python 3.8 from the supported versions list.
  • Ensure the GitHub Actions workflows are updated, particularly removing Python 3.8 from the CI matrix.
  • Review and clean up any testing or build configurations referencing Python versions earlier than 3.11.
  • Run tests in the CI to ensure everything passes after removing Python 3.8.
  • Add a CHANGELOG entry: “Dropped support for Python 3.8.”
  • Bump the package version and release a new version on GitHub & PyPI (if applicable).

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 4, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 4, 2024

Thanks for the pull request, @felipemontoya!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @felipemontoya. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@felipemontoya felipemontoya marked this pull request as ready for review September 10, 2024 20:43
@felipemontoya
Copy link
Member Author

I need to add the changelog and update the dependencies with 3.11

@felipemontoya
Copy link
Member Author

@mariajgrimaldi given your current expertise with the events and filters library what do you think of this PR?

I'm in a lock here as the dependency bot creates PRs that fail because of 3.8 and the only task missing would be to update the references to 3.8 in the requirement txt files.

I would like to merge this as is (or with the review changes as needed) and then update the requirements PR so that it removes the 3.8 references.

Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felipemontoya: This is exactly what was happening with https://github.com/openedx/openedx-events/actions/runs/10658541078/job/29539754138#step:6:23, which was solved by dropping Python 3.8 too openedx/openedx-events#397 -- ignore the docs build failure that is unrelated to the upgrade process.

@felipemontoya felipemontoya merged commit 4bfc9a5 into master Sep 16, 2024
12 checks passed
@felipemontoya felipemontoya deleted the fmo/drop-python3.8 branch September 16, 2024 16:34
@felipemontoya felipemontoya mentioned this pull request Sep 18, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants