-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop python3.8 from support #412
Conversation
Thanks for the pull request, @felipemontoya! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
ececdcc
to
1f0bc39
Compare
I need to add the changelog and update the dependencies with 3.11 |
9de64ad
to
d20f88a
Compare
@mariajgrimaldi given your current expertise with the events and filters library what do you think of this PR? I'm in a lock here as the dependency bot creates PRs that fail because of 3.8 and the only task missing would be to update the references to 3.8 in the requirement txt files. I would like to merge this as is (or with the review changes as needed) and then update the requirements PR so that it removes the 3.8 references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felipemontoya: This is exactly what was happening with https://github.com/openedx/openedx-events/actions/runs/10658541078/job/29539754138#step:6:23, which was solved by dropping Python 3.8 too openedx/openedx-events#397 -- ignore the docs build failure that is unrelated to the upgrade process.
This PR is investigating if I can solve the issues with the update bot by dropping support for 3.8 now that redwood is cut.
https://openedx.atlassian.net/wiki/spaces/COMM/pages/4160847886/2024-04-11+Meeting+notes
From #415:
tox.ini
,setup.py
,setup.cfg
, orpyproject.toml
to remove Python 3.8 from the supported versions list.