Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updating edx-search version to 3.5.0 #32152

Conversation

jfavellar90
Copy link
Contributor

Description

This PR aims to update the version of the edx-search library to 3.5.0. This update will enable operators to have a shared ElasticSearch installation for multiple OpenedX instances. More details about this feature can be found here.

Supporting information

In the Large Instances Working Group we added a feature to have a shared ElasticSearch installation for multiple OpenedX instances in a Kubernetes cluster. To take advantage of this feature in the Palm release, we require the upgrade of the edx-search version.

@openedx-webhooks
Copy link

Thanks for the pull request, @jfavellar90! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@cmltaWt0
Copy link
Contributor

cmltaWt0 commented May 7, 2023

@ghassanmas @regisb
Originally edx-search was upgraded here.
I've tested this backport and everything works fine.
Do you have any objections to merging?

@regisb
Copy link
Contributor

regisb commented May 8, 2023

Seems relatively innocuous. I understand the upgrade is to introduce a new feature (prefix ES indices), so we wouldn't normally accept such a patch, but if it makes everyone's lives easier then I'm fine with that.

If we cannot add the patch to edx-platform then feel free to add it to Tutor, as a cherry-pick.

@cmltaWt0
Copy link
Contributor

cmltaWt0 commented May 8, 2023

Seems relatively innocuous. I understand the upgrade is to introduce a new feature (prefix ES indices), so we wouldn't normally accept such a patch, but if it makes everyone's lives easier then I'm fine with that.

If we cannot add the patch to edx-platform then feel free to add it to Tutor, as a cherry-pick.

Ok, let's talk about this next BTR sync. Personally, I feel like it's better to merge it to the Palm now to avoid any issues in the future (but it's just a feeling).

@regisb
Copy link
Contributor

regisb commented May 9, 2023

I share the same feeling, and I think in this case it's better to apologize than to ask for permission :) I would merge this PR but I don't have the rights.

@ghassanmas
Copy link
Member

I share the same feeling, and I think in this case it's better to apologize than to ask for permission :) I would merge this PR but I don't have the rights.

+1. same as me :)

@cmltaWt0
Copy link
Contributor

cmltaWt0 commented May 9, 2023

@openedx-community-bot merge

@github-actions github-actions bot merged commit 7f654b2 into openedx:open-release/palm.master May 9, 2023
@openedx-webhooks
Copy link

@jfavellar90 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@jfavellar90 jfavellar90 deleted the Jhony/updating_edx_search branch May 16, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants