docs: update ADR for USE-JWT-COOKIE replacement #33680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a part of this ADR details the USE-JWT-COOKIE header which has been removed, this ADR was updated with links to the newer ADR. The status will remain accepted. A change history was also added for this change, as well as documenting some past changes.
This was referenced Nov 8, 2023
|
@feanil: Note: language used in this update assumes forgiven JWTs is the new default. It's debatable as to whether we should also wait for all services to have upgraded to that new version of edx-drf-extensions before landing this as well. UPDATE: I also added related merge tasks to this PR description. |
|
I think this is the direction we want to move in so it's okay to land FWIW. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since a part of this ADR details the USE-JWT-COOKIE header which has been removed, this ADR was updated with links to the newer ADR.
The status will remain accepted.
A change history was also added for this change,
as well as documenting some past changes.
Merge blocker: