VerificationAttempt.expiration_datetime field may be None. #35606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelRoytman
force-pushed
the
michaelroytman/COSMO-521-expiration_datetime-VerificationAttempt-IDVerificationService
branch
3 times, most recently
from
50c224b
to
c0d788a
Compare
MichaelRoytman
force-pushed
the
michaelroytman/COSMO-521-expiration_datetime-VerificationAttempt-IDVerificationService
branch
from
c0d788a
to
597bb7c
Compare
This commit fixes a bug introduced by the new VerificationAttempt model. The expiration_datetime field is nullable. Other IDV models in the verify_student application have a default value for expiration_date, so they are typically not null, despite being nullable. This commit updates code that queries this field to function correctly when the value of expiration_datetime is None. In this case, a None expiration_datetime indicates a non-expiring attempt.
MichaelRoytman
force-pushed
the
michaelroytman/COSMO-521-expiration_datetime-VerificationAttempt-IDVerificationService
branch
from
597bb7c
to
59b9bb8
Compare
MichaelRoytman
deleted the
michaelroytman/COSMO-521-expiration_datetime-VerificationAttempt-IDVerificationService
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira: COSMO-521 (private)
This commit fixes a bug introduced by the new
VerificationAttemptmodel. Theexpiration_datetimefield is nullable. Other IDV models in theverify_studentapplication have a default value forexpiration_date, so they are typically not null, despite being nullable.This commit updates code that queries this field to function correctly when the value of
expiration_datetimeisNone. In this case, aNoneexpiration_datetimeindicates a non-expiring attempt.Supporting information
openedx/platform-roadmap#367
Testing instructions
None.
Deadline
None.
Other information
None.