DO NOT MERGE -- testing Meilisearch in tutor core #35689

pomegranited · 2024-10-22T02:48:00Z

DO NOT MERGE This PR exists solely to deploy a sandbox for overhangio/tutor#1141.

Private-ref: FAL-3903

Settings

# https://github.com/openedx/edx-platform/pull/35743
# + https://github.com/edly-io/edx-platform.git@edly/forumv2 
# ref https://github.com/overhangio/tutor-forum/pull/48/files#diff-0d2d2c5ee050cc46953dd441dc0d4182751734361acf18294183d2928664418eR23-R31
EDX_PLATFORM_REPOSITORY: https://github.com/open-craft/edx-platform.git
EDX_PLATFORM_VERSION: edly/jill/fix-reindex-course-meilisearch

OPENEDX_COMMON_VERSION: master

# Add meilisearch domain to caddy
GROVE_ADDITIONAL_DOMAINS:
- domain: meilisearch.pr-35689-0e7f8a.sandboxes.opencraft.hosting

# https://github.com/openedx/edx-search/pull/162
# + https://github.com/openedx/edx-search/pull/166
OPENEDX_EXTRA_PIP_REQUIREMENTS:
- git+https://github.com/openedx/edx-search.git@master

# Grove expects this variable to be defined
RUN_ELASTICSEARCH: false

# tutor-forum v2 doesn't make an image, so have to omit it from the default
GROVE_IMAGE_BUILD_CONFIG:
  mfe:
    DOCKER_IMAGE_VAR: TUTOR_MFE_DOCKER_IMAGE
  openedx:
    DOCKER_IMAGE_VAR: TUTOR_DOCKER_IMAGE_OPENEDX

PLUGINS:
- mfe
- grove
- forum
- s3
PLUGIN_INDEXES:
- https://overhang.io/tutor/main

# More settings that I don't understand why I need to provide..
ENABLE_HTTPS: true
ENABLE_WEB_PROXY: false
S3_STORAGE_BUCKET: "edx-axim-sandboxes-pr-35689-0e7f8a-9576348626721553780"

# Temporarily required to work around issue in tutor-contrib-grove since Tutor no longer defines RUN_LMS/RUN_CMS:
RUN_CMS: true
RUN_LMS: true

Tutor requirements

# https://github.com/overhangio/tutor/pull/1141
git+https://github.com/overhangio/tutor.git@regisb/meilisearch
# https://github.com/overhangio/tutor-forum/pull/48
# + patch to stop merging edly's edx-platform
git+https://github.com/open-craft/tutor-forum.git@jill/regisb/forumv2
# https://github.com/overhangio/tutor-mfe/pull/231
git+https://github.com/open-craft/tutor-mfe.git@jill/sumac/mfe-enable-meilisearch

# Grove / Harmony
# Support Tutor>=19
git+https://github.com/open-craft/tutor-contrib-s3.git@jill/sumac
# Fix certificate issue
git+https://gitlab.com/opencraft/dev/tutor-contrib-grove.git@4d4ce5c0e258c95c02abce17cc22138ce678fd22
# Support Tutor>=19
git+https://github.com/open-craft/openedx-k8s-harmony.git@jill/sumac#egg=tutor-contrib-harmony-plugin&subdirectory=tutor-contrib-harmony-plugin

openedx-webhooks · 2024-10-22T02:48:04Z

Thanks for the pull request, @pomegranited!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

open-craft-grove · 2024-10-22T07:44:46Z