-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wait for meilisearch index creation to succeed #166
feat: wait for meilisearch index creation to succeed #166
Conversation
Thanks for the pull request, @regisb! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
62a4f3e
to
35974d1
Compare
35974d1
to
dad2cf8
Compare
dad2cf8
to
0960547
Compare
In `search.meilisearch.create_indexes`, we were not waiting for the index creation tasks to complete. This was causing a potential race condition, where the `create_indexes` function would fail because it took a few seconds for the index creation to succeed. See the relevant conversation here: openedx/edx-platform#35743 (comment)
0960547
to
4f27cd5
Compare
Made a new 4.1.1 release for this. Should push to PyPI shortly. |
This is to benefit from the latest changes concerning meilisearch index creation: openedx/edx-search#166
This is to benefit from the latest changes concerning meilisearch index creation: openedx/edx-search#166
This is to benefit from the latest changes concerning meilisearch index creation: openedx/edx-search#166
This is to benefit from the latest changes concerning meilisearch index creation: openedx/edx-search#166
This is to benefit from the latest changes concerning meilisearch index creation: openedx/edx-search#166
In
search.meilisearch.create_indexes
, we were not waiting for the index creation tasks to complete. This was causing a potential race condition, where thecreate_indexes
function would fail because it took a few seconds for the index creation to succeed.See the relevant conversation here:
openedx/edx-platform#35743 (comment)