Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DEPR USE-JWT-COOKIE header #922

Merged
merged 2 commits into from
Aug 29, 2024
Merged

feat: DEPR USE-JWT-COOKIE header #922

merged 2 commits into from
Aug 29, 2024

Conversation

robrap
Copy link
Contributor

@robrap robrap commented Aug 28, 2024

This repo is no longer using USE-JWT-COOKIE header, since it has the required edx-drf-extensions>10.2.0, where it was fully removed.

This is final clean-up for this repo.

See "[DEPR]: USE-JWT-COOKIE header" for more details:

Post-review

  • Squash commits into discrete sets of changes
  • Ensure that once the changes have been deployed to stage, prod is manually deployed

This repo is no longer using USE-JWT-COOKIE header,
since it has the required edx-drf-extensions>10.2.0,
where it was fully removed.

This is final clean-up for this repo.

See "[DEPR]: USE-JWT-COOKIE header" for more details:
- openedx/edx-drf-extensions#371
@@ -21,7 +21,7 @@ edx-auth-backends
edx-celeryutils
edx-django-release-util
edx-django-utils
edx-drf-extensions
edx-drf-extensions>=10.2.0 # removes use-jwt-cookie header
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewer: This is just to ensure this doesn't get downgraded later. This repo is already at 10.3.0.

@robrap robrap merged commit 7f4ae6e into master Aug 29, 2024
4 checks passed
@robrap robrap deleted the robrap/DEPR-USE-JWT-COOKIE branch August 29, 2024 14:30
robrap added a commit that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants