Skip to content

Commit

Permalink
Coupon details refactor and testing (#578)
Browse files Browse the repository at this point in the history
* Move logic to helper functions and test them

* Move action button to a separate component

* Use constants for button labels

* Use index numbers for test names

* Replace ActionButton

Use tested component

* Test shouldShowStatusAlert

* Test default states for bulk actions

* Fix error that occurs if ecommerce is in a weird state by adding defaults for when there is no response from the server

* Move filters to a separate component

Eventually, this component should handle more of the details of changing filters
Update to modern Paragon components to avoid console errors

* Move BulkActions to a separate component

* Update BulkActionSelect to modern component

refactor how table columns are set

* Remove code visibility

This feature was never used and is not a priority

* Update CouponDetails tests

Update Paragon and snapshots

* Rename constants
  • Loading branch information
Lael Birch authored Jun 28, 2021
1 parent 712af16 commit 42035ac
Show file tree
Hide file tree
Showing 30 changed files with 1,244 additions and 4,349 deletions.
1 change: 0 additions & 1 deletion .env.development
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ FEATURE_REPORTING_CONFIGURATIONS=true
FEATURE_ANALYTICS=true
FEATURE_SUPPORT=true
FEATURE_SAML_CONFIGURATION=true
FEATURE_CODE_VISIBILITY=true
FEATURE_EXTERNAL_LMS_CONFIGURATION=true
FEATURE_BULK_ENROLLMENT=true
HOTJAR_APP_ID=''
Expand Down
103 changes: 57 additions & 46 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,19 @@
"license": "AGPL-3.0",
"dependencies": {
"@babel/plugin-transform-runtime": "7.12.1",
"@edx/brand": "npm:@edx/brand-openedx@^1.1.0",
"@edx/brand": "npm:@edx/[email protected]",
"@edx/frontend-enterprise-catalog-search": "0.1.10",
"@edx/frontend-enterprise-logistration": "0.1.11",
"@edx/frontend-enterprise-utils": "0.1.7",
"@edx/frontend-platform": "1.11.0",
"@edx/paragon": "14.12.4",
"@edx/paragon": "14.16.2",
"@fortawesome/fontawesome-svg-core": "1.2.35",
"@fortawesome/free-brands-svg-icons": "5.15.3",
"@fortawesome/free-regular-svg-icons": "5.15.3",
"@fortawesome/free-solid-svg-icons": "5.15.3",
"@fortawesome/react-fontawesome": "0.1.14",
"@fullstory/browser": "1.4.5",
"@redux-beacon/segment": "1.1.0",
"@testing-library/react-hooks": "^5.0.3",
"algoliasearch": "4.8.3",
"axios-mock-adapter": "1.19.0",
"classnames": "2.2.6",
Expand Down Expand Up @@ -89,6 +88,8 @@
"@testing-library/jest-dom": "5.12.0",
"@testing-library/react": "10.4.9",
"@testing-library/user-event": "12.8.3",
"@testing-library/dom": "7.31.2",
"@testing-library/react-hooks": "5.0.3",
"codecov": "3.7.1",
"coveralls": "3.1.0",
"css-loader": "3.5.3",
Expand Down
Loading

0 comments on commit 42035ac

Please sign in to comment.