-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding search/filtering for top-down assignment #1047
Conversation
return cIndex; | ||
}, [config.ALGOLIA_INDEX_NAME, searchClient]); | ||
|
||
const searchFilters = `enterprise_catalog_query_uuids:${offerId}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to confirm that this is the correct filter, only allowing admins to see what is associated with the offerId fetched from the data analytics api.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kiram15 The Algolia filter should be based on a catalog uuid, not a catalog query uuid. The admin portal frontend is generally unaware of catalog queries, only catalog uuids.
As previously discussed, we unfortunately don't have access to the catalog UUID for this page currently as the analytics API (like you noted earlier) only returns catalog_name
, not catalog_uuid
. We will be updating the data source for the LCM feature to no longer pull from the analytics API, in favor of pulling directly from enterprise-access/enterprise-subsidy. Until then, though, we won't have access to a catalog uuid to use in the search filter.
For the short term, we could either temporarily hardcode a catalog UUID until the data is available to the UI (behind a feature flag so not really a concern other than not being able to adequately test your changes on stage/prod at the moment) OR (probably preferable) perhaps tap into the enterprise_customer_catalogs
returned by the https://courses.edx.org/enterprise/api/v1/enterprise-customer/dashboard_list/
API (the source of the enterprise customer metadata for admin portal).
Happy to sync up about short-term options in Slack!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1047 +/- ##
==========================================
- Coverage 83.24% 83.20% -0.05%
==========================================
Files 428 432 +4
Lines 9098 9164 +66
Branches 1861 1875 +14
==========================================
+ Hits 7574 7625 +51
- Misses 1482 1497 +15
Partials 42 42
☔ View full report in Codecov by Sentry. |
Jira ticket
For all changes
Only if submitting a visual change