Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding search/filtering for top-down assignment #1047
feat: Adding search/filtering for top-down assignment #1047
Changes from all commits
f1731d0
4c98238
b758260
3af6502
0cca429
f23330d
b5327f3
2226458
7456635
a14769e
cbcf868
7c98f75
032da45
a3c1812
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 31 in src/components/learner-credit-management/cards/CourseCard.jsx
Codecov / codecov/patch
src/components/learner-credit-management/cards/CourseCard.jsx#L31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[clarification] Is it actually necessary to have custom CSS / elements to support the horizontal card as mocked? I believe you could implement the horizontal cards without any custom CSS.
See this Paragon Playground demo for an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question] Related, is responsiveness a concern for these horizontal cards? For example, at smaller breakpoints (browser window widths), the elements in the horizontal card variants would get fairly squished together, notably in the
Card.Footer
.I might recommend changing the
Card.Footer
orientation fromvertical
tohorizontal
at an appropriate breakpoint and/or updating theCardGrid
and/or itsCard
components to become vertical cards at the small breakpoints.Check warning on line 47 in src/components/learner-credit-management/cards/CourseCard.jsx
Codecov / codecov/patch
src/components/learner-credit-management/cards/CourseCard.jsx#L47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question] Are there supposed to be
Badge
elements for course types other than "Executive Education"? E.g., if it's not "Executive Education", is it supposed to say "Open Courses"?Edit: looks like there is an example for what the
Badge
should say for open courses.Check warning on line 74 in src/components/learner-credit-management/cards/CourseCard.jsx
Codecov / codecov/patch
src/components/learner-credit-management/cards/CourseCard.jsx#L74