Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add members data table to group detail page #1350

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

katrinan029
Copy link
Contributor

Description

Adds a group's data table with pending and registered learners.
https://www.figma.com/design/eMWRd2jVa4Jqc6y7qrUfaa/Groups-Phase-2?node-id=917-55910&t=sZoKuuNnNJvie0bI-1

https://2u-internal.atlassian.net/browse/ENT-9525

Testing

verify that you can filter by searching the member's email address and name, and sort the columns
verify that you see the member's enrollments, added date, and their name/email address

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 marked this pull request as ready for review November 25, 2024 20:18
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 76.59574% with 11 lines in your changes missing coverage. Please review.

Project coverage is 85.50%. Comparing base (3bb7650) to head (438c097).

Files with missing lines Patch % Lines
.../data/hooks/useEnterpriseGroupLearnersTableData.js 80.00% 4 Missing and 2 partials ⚠️
.../components/PeopleManagement/GroupMembersTable.jsx 61.53% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1350      +/-   ##
==========================================
- Coverage   85.53%   85.50%   -0.04%     
==========================================
  Files         601      604       +3     
  Lines       13236    13282      +46     
  Branches     2792     2755      -37     
==========================================
+ Hits        11322    11357      +35     
- Misses       1848     1858      +10     
- Partials       66       67       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant