-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reference to deprecated frontend-lib-content-components repo #209
Conversation
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #209 +/- ##
=======================================
Coverage 83.26% 83.26%
=======================================
Files 47 47
Lines 693 693
Branches 135 135
=======================================
Hits 577 577
Misses 116 116 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's my code and I think it's a copy/paste leftover. Thanks @bradenmacdonald for the cleanup.
@kdmccormick Would you mind giving a +1 on this tiny cleanup PR so I can hit merge? I got +1 from @OmarIthawi but his approval doesn't count as official on this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is there anything that needs to be done to move the translations over from the old repo to the new one in Transifex? Or are the strings shared across all frontend repos?
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
In openedx/frontend-app-authoring#1208 we merged
frontend-lib-content-components
intofrontend-app-course-authoring
, and there is no remaining usage offrontend-lib-content-components
so we will soon be archiving that repo.@OmarIthawi noticed that there is a reference to that deprecated
frontend-lib-content-components
repo in this project. It's unclear to me what it was supposed to be doing, so I'm just removing it for now. As far as I can tell, this app does not actually relate tofrontend-lib-content-components
, and there are no references to it in the code.