Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 18 upgrade #531

Merged

Conversation

abdullahwaheed
Copy link
Contributor

@abdullahwaheed abdullahwaheed commented Jun 2, 2023

Backport node 18 PR for palm release.

  • feat: upgraded to node v18, added .nvmrc and updated workflows

  • refactor: updated packages

  • refactor: resolved eslint issues

Description

Include a description of your changes here, along with a link to any relevant Jira tickets and/or GitHub issues.

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

* feat: upgraded to node v18, added .nvmrc and updated workflows

* refactor: updated packages

* refactor: resolved eslint issues
@abdullahwaheed abdullahwaheed marked this pull request as ready for review June 2, 2023 15:45
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (open-release/palm.master@0e2bd94). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             open-release/palm.master     #531   +/-   ##
===========================================================
  Coverage                            ?   92.37%           
===========================================================
  Files                               ?      163           
  Lines                               ?     3293           
  Branches                            ?      889           
===========================================================
  Hits                                ?     3042           
  Misses                              ?      232           
  Partials                            ?       19           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtyaka mtyaka merged commit 5c6e40b into open-release/palm.master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants