Skip to content

Commit

Permalink
chore: address PR review
Browse files Browse the repository at this point in the history
  • Loading branch information
BryanttV committed Feb 20, 2024
1 parent 39ebc84 commit 6c3fb22
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,12 @@ const messages = defineMessages({
description: 'Scoring weight input label',
},
scoringGradingMethodInputLabel: {
id: 'authoring.problemeditor.settings.scoring.gradingMethod.inputLabel',
id: 'authoring.problemeditor.settings.scoring.grading.method.inputLabel',
defaultMessage: 'Grading Method',
description: 'Grading method input label',
},
gradingMethodSummary: {
id: 'authoring.problemeditor.settings.scoring.gradingMethod',
id: 'authoring.problemeditor.settings.scoring.grading.method',
defaultMessage: '{gradingMethod}',
description: 'Summary text for scoring grading method',
},
Expand Down Expand Up @@ -128,7 +128,7 @@ const messages = defineMessages({
description: 'Summary text for scoring weight',
},
gradingMethodHint: {
id: 'authoring.problemeditor.settings.scoring.gradingMethod.hint',
id: 'authoring.problemeditor.settings.scoring.grading.method.hint',
defaultMessage: 'Define the grading method for this problem. By default, it is the score of the last submission made by the student.',
description: 'Summary text for scoring grading method',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { shallow } from '@edx/react-unit-test-utils';
import { formatMessage } from '../../../../../../../testUtils';
import { scoringCardHooks } from '../hooks';
import { ScoringCard } from './ScoringCard';
import { GradingMethodKeys } from '../../../../../../data/constants/problem';

jest.mock('../hooks', () => ({
scoringCardHooks: jest.fn(),
Expand All @@ -15,7 +16,7 @@ describe('ScoringCard', () => {
unlimited: false,
number: 5,
},
gradingMethod: 'last_score',
gradingMethod: GradingMethodKeys.LAST_SCORE,
updateSettings: jest.fn().mockName('args.updateSettings'),
intl: { formatMessage },
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ exports[`ScoringCard snapshot snapshot: scoring setting card 1`] = `
<FormattedMessage
defaultMessage="Define the grading method for this problem. By default, it is the score of the last submission made by the student."
description="Summary text for scoring grading method"
id="authoring.problemeditor.settings.scoring.gradingMethod.hint"
id="authoring.problemeditor.settings.scoring.grading.method.hint"
/>
</Form.Control.Feedback>
</Form.Group>
Expand Down Expand Up @@ -168,7 +168,7 @@ exports[`ScoringCard snapshot snapshot: scoring setting card max attempts 1`] =
<FormattedMessage
defaultMessage="Define the grading method for this problem. By default, it is the score of the last submission made by the student."
description="Summary text for scoring grading method"
id="authoring.problemeditor.settings.scoring.gradingMethod.hint"
id="authoring.problemeditor.settings.scoring.grading.method.hint"
/>
</Form.Control.Feedback>
</Form.Group>
Expand Down Expand Up @@ -283,7 +283,7 @@ exports[`ScoringCard snapshot snapshot: scoring setting card zero zero weight 1`
<FormattedMessage
defaultMessage="Define the grading method for this problem. By default, it is the score of the last submission made by the student."
description="Summary text for scoring grading method"
id="authoring.problemeditor.settings.scoring.gradingMethod.hint"
id="authoring.problemeditor.settings.scoring.grading.method.hint"
/>
</Form.Control.Feedback>
</Form.Group>
Expand Down

0 comments on commit 6c3fb22

Please sign in to comment.