Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback link is hardcoded to a 2U Google Form #476

Closed
kdmccormick opened this issue May 9, 2024 · 2 comments · Fixed by #493
Closed

Feedback link is hardcoded to a 2U Google Form #476

kdmccormick opened this issue May 9, 2024 · 2 comments · Fixed by #493
Labels
business-specific Code that relates to a specific user and should be refactored and removed. release testing Affects the upcoming release (attention needed)

Comments

@kdmccormick
Copy link
Member

The "Share Feedback" link:

image

Goes to:

image

We can't be directing Open edX users to a form hosted on 2U's Google account.
@kdmccormick kdmccormick added the release testing Affects the upcoming release (attention needed) label May 9, 2024
@kdmccormick kdmccormick added the business-specific Code that relates to a specific user and should be refactored and removed. label May 9, 2024
@KristinAoki KristinAoki mentioned this issue Jul 10, 2024
Merged
@KristinAoki KristinAoki linked a pull request Jul 10, 2024 that will close this issue
fix: remove deprecated feedback link #493
Merged
@kdmccormick
Copy link
Member Author

Thanks for the fix @KristinAoki . Could you backport this to Redwood as well?

@kdmccormick kdmccormick reopened this Jul 16, 2024
@kdmccormick kdmccormick moved this from Done to In progress in Build-Test-Release Working Group Jul 18, 2024
@KristinAoki KristinAoki mentioned this issue Jul 19, 2024
Merged
kdmccormick added a commit to openedx/frontend-app-authoring that referenced this issue Jul 23, 2024
@KristinAoki @kdmccormick
feat: bump frontend-lib-content-components to 2.5.1 (#1174)
d80a681 
The primary purpose of this version bump backport is to remove the 2U feedback form
link from the editors (openedx/frontend-lib-content-components#476),
but several other improvements will also be pulled in:

* Fix the Text editor so that when an image is added, it is added at the cursor,
  instead of the beginning of the component.
* Improve editor load time by reducing API calls and switching some calls to be lazy.
* Align controls better in the group feedback component.
* Add validation for start & stop date fields.
* Fix image handling bugs in both the raw & visual text editors.

Full changelog: openedx/frontend-lib-content-components@v2.1.11...v2.5.1

Co-authored-by: Kyle McCormick <[email protected]>
bra-i-am pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this issue Aug 9, 2024
@KristinAoki @kdmccormick @bra-i-am
feat: bump frontend-lib-content-components to 2.5.1 (openedx#1174)
23ac1f9 
The primary purpose of this version bump backport is to remove the 2U feedback form
link from the editors (openedx/frontend-lib-content-components#476),
but several other improvements will also be pulled in:

* Fix the Text editor so that when an image is added, it is added at the cursor,
  instead of the beginning of the component.
* Improve editor load time by reducing API calls and switching some calls to be lazy.
* Align controls better in the group feedback component.
* Add validation for start & stop date fields.
* Fix image handling bugs in both the raw & visual text editors.

Full changelog: openedx/frontend-lib-content-components@v2.1.11...v2.5.1

Co-authored-by: Kyle McCormick <[email protected]>
@mariajgrimaldi
Copy link
Member

I'll close this as completed since it was backported successfully to redwood. Thank you!

@github-project-automation github-project-automation bot moved this from In progress to Done in Build-Test-Release Working Group Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
business-specific Code that relates to a specific user and should be refactored and removed. release testing Affects the upcoming release (attention needed)
Projects
Build-Test-Release Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove deprecated feedback link openedx/frontend-lib-content-components
2 participants
@kdmccormick @mariajgrimaldi