Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR for organizing our folder structure in a feature-based manner #296

Conversation

jesperhodge
Copy link
Member

@jesperhodge jesperhodge commented Apr 5, 2023

This is linked to issue openedx/frontend-app-authoring#1239 .

context:

We would like to improve our folder structure to make it more scalable and to separate redux for "framework" purposes - like saving xblocks - from redux for internal editor state. We want to organize our redux better and also organize our components by feature, rather than just keeping them deeply nested in some parent component folders. (read more about all of this in the issue linked above.)

The ADR is not one I have created. It is an ADR used by many openedx-repositories and based on community best practices. We want to review it, and if accepted, adopt it.

Later, not as part of this PR, we would like to add our own, second, ADR that is very specific to this repository and decides more of the "how" to implement what this feature-based organization ADR recommends.

This should be reviewed by our whole team and requires everyone's approval.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.58%. Comparing base (1d66a9d) to head (2ddc214).
Report is 211 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #296   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files         215      215           
  Lines        3717     3717           
  Branches      717      717           
=======================================
  Hits         3367     3367           
  Misses        329      329           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesperhodge jesperhodge merged commit 8cd222b into openedx:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants