Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixed delete for additional video url fields #418

Closed
wants to merge 4 commits into from
Closed

feat: Fixed delete for additional video url fields #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d8cd2d
feat: fixed delete button
vladislavkeblysh Nov 1, 2023
52ca46f
feat: fixed tests
vladislavkeblysh Dec 29, 2023
1942b1c
feat: fixed tests
vladislavkeblysh Dec 29, 2023
c99bfe1
feat: fixed delete button
vladislavkeblysh Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...ponents/VideoSettingsModal/components/VideoSourceWidget/__snapshots__/index.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ exports[`VideoSourceWidget snapshots snapshots: renders as expected with default
<IconButtonWithTooltip
alt="Delete"
iconAs="Icon"
key="top-delete-somEUrL"
onClick={[Function]}
tooltipContent="Delete"
tooltipPlacement="top"
Expand Down Expand Up @@ -235,7 +234,6 @@ exports[`VideoSourceWidget snapshots snapshots: renders as expected with videoSh
<IconButtonWithTooltip
alt="Delete"
iconAs="Icon"
key="top-delete-somEUrL"
onClick={[Function]}
tooltipContent="Delete"
tooltipPlacement="top"
Expand Down
9 changes: 7 additions & 2 deletions ...ntainers/VideoEditor/components/VideoSettingsModal/components/VideoSourceWidget/hooks.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,13 @@ export const sourceHooks = ({ dispatch, previousVideoId, setAlert }) => ({

export const fallbackHooks = ({ fallbackVideos, dispatch }) => ({
addFallbackVideo: () => dispatch(actions.video.updateField({ fallbackVideos: [...fallbackVideos, ''] })),
deleteFallbackVideo: (videoUrl) => {
const updatedFallbackVideos = fallbackVideos.splice(fallbackVideos.indexOf(videoUrl), 1);

deleteFallbackVideo: (videoIndex) => {
const updatedFallbackVideos = fallbackVideos.reduce((result, currentItem, index) => {
if (index === videoIndex) { return result; }
return [...result, currentItem];
}, []);

dispatch(actions.video.updateField({ fallbackVideos: updatedFallbackVideos }));
},
});
Expand Down
3 changes: 1 addition & 2 deletions ...ntainers/VideoEditor/components/VideoSettingsModal/components/VideoSourceWidget/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,12 @@ export const VideoSourceWidget = ({
onBlur={fallbackVideos.onBlur(index)}
/>
<IconButtonWithTooltip
key={`top-delete-${videoUrl}`}
tooltipPlacement="top"
tooltipContent={intl.formatMessage(messages.deleteFallbackVideo)}
src={DeleteOutline}
iconAs={Icon}
alt={intl.formatMessage(messages.deleteFallbackVideo)}
onClick={() => deleteFallbackVideo(videoUrl)}
onClick={() => deleteFallbackVideo(index)}
/>
</Form.Row>
)) : null}
Expand Down
Loading