Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validation for Start time and Stop time fields #419

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

vladislavkeblysh
Copy link
Contributor

  • Fixed validations for startTime and stopTime fields.

stopTime value must not be equal to 24:00:00, because this value is not valid so when the user types 23:59:59 in the startTime field and stopTime field - set the startTime field to 23:59:58.

Screenshot 2023-11-05 at 16 22 51

Screenshot 2023-11-05 at 16 23 09

@openedx-webhooks
Copy link

openedx-webhooks commented Nov 5, 2023

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 5, 2023
@vladislavkeblysh vladislavkeblysh marked this pull request as draft November 5, 2023 14:23
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3aa9088) 90.49% compared to head (6604493) 90.50%.
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   90.49%   90.50%   +0.01%     
==========================================
  Files         228      228              
  Lines        4115     4120       +5     
  Branches      822      823       +1     
==========================================
+ Hits         3724     3729       +5     
  Misses        370      370              
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vladislavkeblysh vladislavkeblysh marked this pull request as ready for review November 25, 2023 13:22
@mphilbrick211 mphilbrick211 requested a review from a team December 11, 2023 18:45
@mphilbrick211
Copy link

Hi @openedx/teaching-and-learning! Would someone be able to review this for us? Thanks!

@mphilbrick211
Copy link

Hi @openedx/2u-tnl! Would someone be able to please review / merge this for us? Thanks!

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 21, 2024
@mphilbrick211 mphilbrick211 requested a review from a team March 21, 2024 01:42
@mphilbrick211
Copy link

Hi @openedx/2u-tnl! Would someone be able to please review / merge this for us? Thanks!

@KristinAoki KristinAoki merged commit c84e322 into openedx:main Jun 18, 2024
5 checks passed
@openedx-webhooks
Copy link

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants