-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Validation for Start time and Stop time fields #419
feat: Validation for Start time and Stop time fields #419
Conversation
Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 90.49% 90.50% +0.01%
==========================================
Files 228 228
Lines 4115 4120 +5
Branches 822 823 +1
==========================================
+ Hits 3724 3729 +5
Misses 370 370
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Hi @openedx/teaching-and-learning! Would someone be able to review this for us? Thanks! |
Hi @openedx/2u-tnl! Would someone be able to please review / merge this for us? Thanks! |
Hi @openedx/2u-tnl! Would someone be able to please review / merge this for us? Thanks! |
@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
stopTime value must not be equal to 24:00:00, because this value is not valid so when the user types 23:59:59 in the startTime field and stopTime field - set the startTime field to 23:59:58.