-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: license widget checkbox and link #486
fix: license widget checkbox and link #486
Conversation
Thanks for the pull request, @khudym! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
e323793
to
e5f17ef
Compare
e5f17ef
to
49559e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
+ Coverage 88.84% 88.92% +0.07%
==========================================
Files 248 248
Lines 4529 4540 +11
Branches 928 943 +15
==========================================
+ Hits 4024 4037 +13
+ Misses 474 470 -4
- Partials 31 33 +2 ☔ View full report in Codecov by Sentry. |
@khudym 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Steps to reproduce
Basic setup
Go to
studio -> unit -> Video block -> scroll to the end of editors page and click on the "Add a license for this video" button
.basic setup -> in the "License type" field select "Creative Commons" -> Check Share alive (No derivatives unchecked) -> save -> open for edit again
ACTUAL RESULT: Share Alike option is displayed as unchecked
EXPECTED RESULT: Share Alike option is displayed as checked
basic setup -> in the "License type" field select "All Rights Reserved".
ACTUAL RESULT: View license details with link to https://creativecommons.org/about/ is displayed below
EXPECTED RESULT: this link only displayed for Creative Commons license type