Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: license widget checkbox and link #486

Merged

Conversation

khudym
Copy link
Contributor

@khudym khudym commented Jun 19, 2024

Description

  • The "Share alike" checkbox now works correctly after selecting and saving it.
  • The "View license details" link is only displayed for Creative Commons license type.

Steps to reproduce

Basic setup
Go to studio -> unit -> Video block -> scroll to the end of editors page and click on the "Add a license for this video" button.

  1. "Share alike" issue:

basic setup -> in the "License type" field select "Creative Commons" -> Check Share alive (No derivatives unchecked) -> save -> open for edit again

ACTUAL RESULT: Share Alike option is displayed as unchecked

share_alike_AC

EXPECTED RESULT: Share Alike option is displayed as checked

License_widget_sharealike

  1. "View license details link" issue:

basic setup -> in the "License type" field select "All Rights Reserved".

ACTUAL RESULT: View license details with link to https://creativecommons.org/about/ is displayed below

EXPECTED RESULT: this link only displayed for Creative Commons license type

all_rights_reserved_no_link

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 19, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 19, 2024

Thanks for the pull request, @khudym! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@khudym khudym force-pushed the hudym/video-license-enhancements branch 2 times, most recently from e323793 to e5f17ef Compare June 20, 2024 20:26
@khudym khudym changed the title 1) fix active Share alive checkbox; 2) show license details link only… fixes to the license widget Jun 21, 2024
@khudym khudym force-pushed the hudym/video-license-enhancements branch from e5f17ef to 49559e3 Compare June 21, 2024 09:45
@khudym khudym changed the title fixes to the license widget fix: license widget checkbox and link Jun 22, 2024
@khudym khudym marked this pull request as ready for review July 3, 2024 07:25
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (6a58779) to head (65eefec).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   88.84%   88.92%   +0.07%     
==========================================
  Files         248      248              
  Lines        4529     4540      +11     
  Branches      928      943      +15     
==========================================
+ Hits         4024     4037      +13     
+ Misses        474      470       -4     
- Partials       31       33       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 requested a review from a team July 17, 2024 13:34
@KristinAoki KristinAoki merged commit a9e8bd5 into openedx:main Aug 16, 2024
7 checks passed
@openedx-webhooks
Copy link

@khudym 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@ihor-romaniuk ihor-romaniuk deleted the hudym/video-license-enhancements branch August 20, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants