Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove imports breaking build #500

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

KristinAoki
Copy link
Member

@KristinAoki KristinAoki commented Aug 2, 2024

This PR removes paragon scss variable imports from .scss files. These imports break the build of the course authoring MFE because of a ModuleErrorBuild. The only variable used is $gray-500 and the hex code for the variable is the same in the openedX and edX themes, #707070, so replacement will have no affect on the UI

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (beb4813) to head (295008e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files         248      248           
  Lines        4554     4554           
  Branches      943      939    -4     
=======================================
  Hits         4049     4049           
  Misses        472      472           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki enabled auto-merge (squash) August 2, 2024 14:13
@KristinAoki KristinAoki merged commit b68257e into main Aug 2, 2024
10 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-imports-breaking-build branch August 2, 2024 19:04
@bradenmacdonald
Copy link
Contributor

If you prefer to keep the variables, I think open-craft@5ff22c1 would fix the error; assuming it's the same as a similar error I recently saw. This fix seems fine too though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants