-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore!: Updating for Python 3.12 #121
Conversation
Thanks for the pull request, @Colin-Fredericks! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@Colin-Fredericks looks like there is a confilict, I think you need to rebase your local master on top of the |
How's that? |
I'm not 100% sure why the 3.8 tests went away from the workflow but there's no 3.12 test. Sort of expected that to appear automatically I guess. 🤷 |
Since you haven't committed here before, the test runs have to be approved, and so it lists the pending set of required tests and doesn't run all the tests. I've approved it and both the 3.11 and 3.12 test have run. It looks like the conventional commits check is failing. Sorry for not mentioning that we use conventional commits on all the code repos now. Can you update the commit messages to use the conventional commits structure? |
Ah, ok. I think I found an older version of the commit guidelines. Will edit. Edit: Oh, wait, that's what happened - I saw these commit guidelines and read them as "how to write a pull request" instead of "how to write a commit message". Fixing. |
7cf310a
to
4eb7400
Compare
Sigh. Revising old commits is apparently a nightmare, and I can't squash this set of commits. It may be worth me just erasing this pull request, redoing the commits from the ground up, and making a new pull request. |
You should be able to do an interactive rebase and just re-word the commits: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#_changing_multiple |
@Colin-Fredericks let me know if you want to work through the rebasing together. |
5d79cc2
to
f78c25d
Compare
Update README with current default structure
Adding pytest to enable later test changes
Switching from 3.8 to 3.12, and going from setup.py to pytest
Pulling in bot suggestions for non-breaking changes to a large number of packages. BREAKING CHANGE: I'm not 100% certain about this, but the odds seem good that some of the package updates remove backward-compatibility with Python 3.8. Since the intent of this whole pull request is to move from 3.8 to 3.12, I don't feel like I need to double-check.
Look that's just how many positional arguments there are ok?
Adding the basics of how to test and set up the repo locally.
Found another one to fix.
Found another one
Major version bump for breaking change
@feanil I ran into some issues changing old commits because of the merge, so the force push was to undo that. Is this better? |
Hmm, ok, linting still failing so it's still seeing the old commits. |
c0a977f
to
9917c1c
Compare
AHA! Got it to drop the old commits from the pull request. |
Nice, thanks Colin, I'll merge and release these changes! |
This addresses items from #109 and #120.
Overview:
pylint
that it's ok when certain functions have lots of inputs.BREAKING CHANGE: Python 3.8 no longer supported. This commit by itself doesn't do that, but odds are good that some of the package updates do.
Thank you to Feanil for the help!