-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix github url strings (org edx -> openedx) #63
Conversation
d01cdc3
to
d78a345
Compare
@Jawayria or @rayzhou-bit - since you've last committed to this repo could you help me here? I updated
From a quick Google it seems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks close. Minor fix needed.
pylintrc_backup
Outdated
@@ -0,0 +1,387 @@ | |||
# *************************** | |||
# ** DO NOT EDIT THIS FILE ** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this file, and also add it to .gitignore
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, not sure if you can do this for all your PRs that have this problem.
FYI: @nedbat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this comes when you do an edx_lint write <file>
but the last time it was edited, it was done manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ned brought up that this is a temporary file that isn't meant to be committed, and we discussed possible solutions around this using .gitignore
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely don't commit this file. Ideally use it to figure out what previous hand-edited change needs to be moved to a pylintrc_tweaks file.
I'm conflicted about whether to add it to .gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarina: We could always loop back and add to .gitignore later, so maybe you can just delete this file for now so we can get this PR through. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it in latest commit but held off on gitignore.
The reason I could see not having it in gitignore is because it's a signal you updated it manually last time. however if that's the case, we should rename the file to make it clear why it's being generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I might leave it out of .gitignore is that it is not an expected artifact of normal operations. As Sarina says, it's a bit of a warning. So I'd leave it more visible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As-is, I think people will not understand what it is for and it will get committed and possibly merged. If you are thinking about additional checks around all this, something that failed the build if this file is found, with a clear message about why and how to fix would be useful. Again, as-is, I don't think you'll get what you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that simply letting the file get committed will not get what I want. I'm looking over possibilities for checking for the file automatically as a linting operation.
@@ -287,7 +286,6 @@ disable = | |||
illegal-waffle-usage, | |||
|
|||
logging-fstring-interpolation, | |||
django-not-available, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the hand-edited line that is now missing from pylintrc, and is causing the linting failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah thanks, I'll add that to _tweaks
751e7f7
to
ef451bd
Compare
@nedbat I've seen this in another repo:
I poked at this error and was not able to figure out what to do based on examples from |
Thought the last change got it to green.
You've added a line to pylintrc_tweaks, now you need to run |
uggggh i know that AND YET! I keep forgetting to do it. |
ef451bd
to
5b1f915
Compare
Build is green, if someone wants to give me a final review (last commit actually applied the new pylintrc_tweaks to pylintrc) |
This PR was autogenerated
This pr replaces the old GitHub organization, github.com/edx, with the new GitHub organization, github.com/openedx.
Tagging @openedx/tcril-engineering for review, but others are welcome to provide review.
Ref: openedx/axim-engineering#42