-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: split AvroAttrsBridge into distinct methods #60
Conversation
bc6d37d
to
3d19827
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I like that the different modules keep a clear distinction between schema, serialization, and deserialization code.
3186715
to
72c0fef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Becca. I want to help wrap up this PR quickly, so if anything needs discussion, maybe we can handle that synchronously to land this more easily?
I added lots of comments, but many are suggested changes. If you like the change, I highly recommend you just click the "Add suggestion to batch" button to make your life easier, and then add a commit with all the changes.
Some of the test recommendation updates I made aren't really blockers. If they are quick, please update. Otherwise, you can either note that you are skipping and/or we could add a TODO for potential future clean-up.
Thank you!
docs/decisions/0004-external-event-bus-and-django-signal-events.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Raposa <[email protected]>
Co-authored-by: Robert Raposa <[email protected]>
…b.com/openedx/openedx-events into rsgraber/ARCHBOM-2102-refactor-bridge
Co-authored-by: Robert Raposa <[email protected]>
Co-authored-by: Robert Raposa <[email protected]>
Description: Split the AvroAttrsBridge into several different modules/classes to separate the schema generation, serialization, and deserialization phases.
JIRA: ARCHBOM-2102
GH Issue: #65
Testing instructions:
Usage described in How-to
Reviewers:
Merge checklist:
Post merge:
finished.