-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ORA filter for submission view rendering intervention #158
feat: add ORA filter for submission view rendering intervention #158
Conversation
Thanks for the pull request, @BryanttV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
ae95cfb
to
e94df6a
Compare
Hi @mariajgrimaldi, this PR is ready for review. The checks fail due to an error in the execution of the coverage workflow. |
ecc6947
to
6c0e69c
Compare
You can rebase with main to fix the issue, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! LGTM
Let me know when you rebase with main so I can merge.
6c0e69c
to
224bcf3
Compare
Hi @mariajgrimaldi, PR updated, thank you! |
@BryanttV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds a filter to modify the default template of submissions in an ORA assignment.
ORASubmissionViewRenderStarted
RenderInvalidTemplate
Supporting Information
These changes are based on those proposed in the following ADR