-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extract translations from frontend-app-ora #7445
feat: extract translations from frontend-app-ora #7445
Conversation
Thank you so much for this PR! Would you be able to verify the change to |
Hey @brian-smith-tcril , none of the workflows here transferred over to my fork. Is there a standard process to get these set up? |
Okay, @brian-smith-tcril , I did a bit of research and troubleshooting but figured it out. Capturing what I found here for folks who may run into something similar.
After those, I was then able to ✅ successfully run the workflow creating these files on this new branch . My question: is success in running that job all that is needed for verification? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for writing up the changes you needed to make to verify it on your fork! It looks like the generated file is valid and the path matches the one you added to transifex.yml
so this should be good to go!
Excellent, thanks for checking back in, @brian-smith-tcril. I'm unable to merge so are you able to merge this PR? |
Add frontend-app-ora to list of MFEs with openedx-translation-managed translations.