feat: slightly more detailed types for <Chip/ChipIcon> - per review

openedx · Jul 5, 2024 · 4aee81f · 4aee81f
1 parent 4cd7029
commit 4aee81f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Chip/ChipIcon.tsx b/src/Chip/ChipIcon.tsx
@@ -7,11 +7,11 @@ import { STYLE_VARIANTS } from './constants';
 export type ChipIconProps = {
   className: string,
   src: React.ComponentType,
-  variant: string,
+  variant: typeof STYLE_VARIANTS[keyof typeof STYLE_VARIANTS],
   disabled?: boolean,
 } & (
   // Either _both_ onClick and alt are provided, or neither is:
-  | { onClick: KeyboardEventHandler & MouseEventHandler, alt: string }
+  | { onClick: KeyboardEventHandler<HTMLButtonElement> & MouseEventHandler<HTMLButtonElement>, alt: string }
   | { onClick?: undefined, alt?: undefined }
 );
 

diff --git a/src/Chip/index.tsx b/src/Chip/index.tsx
@@ -12,7 +12,7 @@ export interface IChip {
   children: React.ReactNode,
   onClick?: KeyboardEventHandler & MouseEventHandler,
   className?: string,
-  variant?: string,
+  variant?: typeof STYLE_VARIANTS[keyof typeof STYLE_VARIANTS],
   iconBefore?: React.ComponentType,
   iconBeforeAlt?: string,
   iconAfter?: React.ComponentType,