feat: add typings for <Button> (#3080)

* feat: add typings for <Button> * chore: bump @types/react and @types/react-dom * feat: re-export bootstrap helpers as ComponentWithAsProp, BsPropsWithAs
openedx · Nov 26, 2024 · 98fe4a5 · 98fe4a5
1 parent 6e0cca5
commit 98fe4a5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/Chip/ChipIcon.tsx b/src/Chip/ChipIcon.tsx
@@ -7,7 +7,9 @@ import { STYLE_VARIANTS } from './constants';
 export type ChipIconProps = {
   className: string,
   src: React.ComponentType,
-  variant: typeof STYLE_VARIANTS[keyof typeof STYLE_VARIANTS],
+  onClick?: KeyboardEventHandler & MouseEventHandler,
+  alt?: string,
+  variant: string,
   disabled?: boolean,
 } & (
   // Either _both_ onClick and alt are provided, or neither is:

diff --git a/src/Modal/_ModalDialog.scss b/src/Modal/_ModalDialog.scss
@@ -100,10 +100,6 @@
   .pgn__modal-header {
     border-radius: 0;
   }
-
-  .pgn__modal-header {
-    border-radius: 0;
-  }
 }
 
 // Made specific due to a selector in Modal.scss