Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): update @storybook/react to version 3.3.10 #129

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

jaebradley
Copy link
Contributor

Closes #117

@coveralls
Copy link

coveralls commented Jan 22, 2018

Coverage Status

Coverage remained the same at 99.563% when pulling 1619490 on greenkeeper/@storybook/react-3.3.10 into 594829a on master.

Closes #117

build(storybook): update react

build(storybook): update all storybook dependencies
@jaebradley jaebradley force-pushed the greenkeeper/@storybook/react-3.3.10 branch from 0c22dfe to 1619490 Compare January 22, 2018 18:52
@jaebradley
Copy link
Contributor Author

jaebradley commented Jan 22, 2018

I was running into these weird errors after upgrading @storybook/react
screen shot 2018-01-22 at 1 44 12 pm

I came across @storybook#1981 - one of the suggestions was to upgrade/reinstall all @storybook dependencies.

After upgrading each dependency one at a time, after upgrading @storybook/storybook-deployer to 2.2.0 the errors went away.

I decided to keep all the upgraded @storybook dependencies as part of this PR.

@jaebradley jaebradley requested a review from arizzitano January 22, 2018 18:56
Copy link
Contributor

@thallada thallada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jaebradley jaebradley merged commit f3aaa58 into master Jan 25, 2018
@jaebradley jaebradley deleted the greenkeeper/@storybook/react-3.3.10 branch January 25, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants