Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: testeng-ci #265

Closed
5 tasks done
Tracked by #612
kdmccormick opened this issue May 14, 2024 · 3 comments
Closed
5 tasks done
Tracked by #612

[DEPR]: testeng-ci #265

kdmccormick opened this issue May 14, 2024 · 3 comments
Assignees
Labels
depr Proposal for deprecation & removal per OEP-21

Comments

@kdmccormick
Copy link
Member

kdmccormick commented May 14, 2024

Proposal Date

2024-05-14

Target Ticket Acceptance Date

2024-05-28

Earliest Open edX Named Release Without This Functionality

Redwood

Rationale

This is a tiny repo with a couple Python modules for interacting with GitHub. They are used in a handful of GitHub Actions workflows that open PRs. It could easily be merged into repo-tools.

Removal

This repository will be archived and it will not be part of the Open edX named release, starting with Redwood.

(the repo contains a redwood.master branch, but it will not get redwood.1 tag if this is accepted in time)

Replacement

This repo used to have a bunch of scripts used by edX's Jenkins server. Those have mostly all been replaced in a community-friendly way with a mix of GitHub Actions workflows, scripts in app repos, and Tutor.

The remaining module that Open edX still uses, pull_request_creator, will be moved into repo-tools: openedx/repo-tools#517

Deprecation

I'll put a notice in the README.

Migration

Workflows that currently clone and install testeng-ci for the pull_request_creator tool should instead:

git clone https://github.com/openedx/repo-tools
pip install -e .[pull_request_creator]
pull_request_creator ...

Additional Info

N/A

Task List

  1. github-request
    kdmccormick
@github-actions github-actions bot added the depr Proposal for deprecation & removal per OEP-21 label May 14, 2024
@kdmccormick kdmccormick self-assigned this May 14, 2024
@kdmccormick
Copy link
Member Author

@kdmccormick
Copy link
Member Author

@robrap I had originally mentioned on this ticket that 2U would probably need to fork testeng-ci from openedx-unsupported and continue maintaining it in the edx org, but I believe I was mistaken. I thought that this repo supported 2U jenkins infrastructure; my understanding now is that all the Jenkins stuff has already been removed.

All that remains in testeng-ci today is the pull_request_creator script, which several of our shared GitHub workflows use. So, for this DEPR, we'll move that script to repo-tools and then archive testeng-ci. If there's any 2U work, it'll just be updating of references in your own GitHub workflows from testeng-ci to repo-tools. Thanks to GH's forwarding, that won't be time sensitive, unless GHA ever makes a change that breaks the script in openedx-unsupported/testeng-ci.

kdmccormick referenced this issue in openedx/repo-tools Jun 5, 2024
kdmccormick referenced this issue in kdmccormick/openedx.github Jun 5, 2024
testeng-ci is deprecated in favor of repo-tools [1]

This includes some cosmetic changes to the upgrade PRs.

Before:
* branch == jenkins/upgrade-python-requirements-{id}
* title  == Python Requirements Update
* commit == chore: Updating Python Requirements

After:
* branch == repo-tools/upgrade-python-requirements-{id}
* title  == chore: Upgrade Python requirements
* commit == chore: Upgrade Python requirements

NOTE: This leaves behind a testeng-ci reference in the repo-health job.
We need to figure out whether to fix the repo health dashboard or
deprecate it. This will a follow up task after [1] is closed.

[1] https://github.com/openedx/testeng-ci/issues/419
kdmccormick referenced this issue in kdmccormick/openedx.github Jun 5, 2024
testeng-ci is deprecated in favor of repo-tools [1]

This includes some cosmetic changes to the upgrade PRs.

Before:
* branch == jenkins/upgrade-python-requirements-{id}
* title  == Python Requirements Update
* commit == chore: Updating Python Requirements

After:
* branch == repo-tools/upgrade-python-requirements-{id}
* title  == chore: Upgrade Python requirements
* commit == chore: Upgrade Python requirements

NOTE: This leaves behind a testeng-ci reference in the repo-health job.
We need to figure out whether to fix the repo health dashboard or
deprecate it. This will a follow up task after [1] is closed.

[1] https://github.com/openedx/testeng-ci/issues/419
@kdmccormick kdmccormick transferred this issue from openedx-unsupported/testeng-ci Jun 5, 2024
kdmccormick added a commit to openedx-unsupported/testeng-ci that referenced this issue Jun 6, 2024
kdmccormick added a commit to openedx/.github that referenced this issue Jun 7, 2024
testeng-ci is deprecated in favor of repo-tools.
See the DEPR [1] and the PR that moved pull_request_creator to repo-tools [2].

This also includes some cosmetic changes to the upgrade PRs.

Before:
* branch == jenkins/upgrade-python-requirements-{id}
* title  == Python Requirements Update
* commit == chore: Updating Python Requirements

After:
* branch == repo-tools/upgrade-python-requirements-{id}
* title  == chore: Upgrade Python requirements
* commit == chore: Upgrade Python requirements

NOTE: This leaves behind a testeng-ci reference in the repo-health job. We need to figure out the future of the edx-repo-health repo. This will be a future task [3]

[1] openedx/public-engineering#265
[2] openedx/repo-tools#517
[3] #138
@kdmccormick
Copy link
Member Author

Replacement and removal is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
Archived in project
Development

No branches or pull requests

1 participant